Part of #1238484: Ability to mark the form buttons to be of a specific type (so that they can be styled differently). I am here marking all the buttons in structure blue.

To keep this patch effort, somewhat manageable I am doing it per section.

CommentFileSizeAuthor
#10 1850182-10.patch5.13 KBswentel
#3 all.buttons.structure.blue_.patch5.11 KBBojhan
#3 views-saveconfig.png62.88 KBBojhan
#3 taxonomy-save.png25.42 KBBojhan
#3 taxonomy-termlisting-save.png29.53 KBBojhan
#3 menu-saveconfiguration.png19.15 KBBojhan
#3 blocks-listingsave.png19.96 KBBojhan
#1 forum-addedit.png32.34 KBBojhan
#1 forumcontainer-addedit.png32.84 KBBojhan
#1 menu-addandedit.png44.25 KBBojhan
#1 menumanage-editandadd.png17.33 KBBojhan
#1 listings.blue_.buttons.patch2.16 KBBojhan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Bojhan’s picture

Bojhan CreditAttribution: Bojhan commented
FileSize
listings.blue_.buttons.patch2.16 KB
menumanage-editandadd.png17.33 KB
menu-addandedit.png44.25 KB
forumcontainer-addedit.png32.84 KB
forum-addedit.png32.34 KB

This is basically, for all usecases were we have two buttons.

Because we are not yet sure, we want it on all primary buttons - I didn't do that here.

Bojhan’s picture

Bojhan CreditAttribution: Bojhan commented
Status: Active » Needs review
Bojhan’s picture

Bojhan CreditAttribution: Bojhan commented
FileSize
blocks-listingsave.png19.96 KB
menu-saveconfiguration.png19.15 KB
taxonomy-termlisting-save.png29.53 KB
taxonomy-save.png25.42 KB
views-saveconfig.png62.88 KB
all.buttons.structure.blue_.patch5.11 KB

Now the patch to mark all primary buttons blue in Structure.

  • Noticed some inconsistencies:
  • "Save blocks" -> We normally just call this "Save"
  • Blocks config has no delete link
 

*This has a serious side-effect, it also marks all forms that implement system_config_form its "Save configuration" buttons blue.

swentel’s picture

swentel CreditAttribution: swentel commented
Status: Needs review » Needs work 
+++ b/core/modules/block/block.admin.incundefined
@@ -173,6 +173,7 @@ function block_admin_display_form($form, &$form_state, $blocks, $theme, $block_r
+	'#button_type' => 'primary',

Tabs instead of spaces everywhere you put #button_type

+++ b/core/modules/menu/menu.admin.incundefined
@@ -407,8 +408,8 @@ function menu_edit_item($form, &$form_state, $type, $item, $menu) {
+ ¶

A space

Bojhan’s picture

Bojhan CreditAttribution: Bojhan commented
Status: Needs work » Needs review

Cool, that can be fixed.

Setting this back to review to get more feedback on changing the UI guideline, from using blue buttons "everywhere there are two buttons" to "everywhere we can find a primary button".

yoroy’s picture

yoroy CreditAttribution: yoroy commented

Yes, I think that makes sense. It will make that blue button something you can rely on, you can click it and the form will be submitted/your stuff will be saved. Lets do this :)

Shyamala’s picture

Shyamala CreditAttribution: Shyamala commented
Component: toolbar.module » other

This is not part of toolbar module...

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented

The screenshots in #3 look a bit weird to me. OTOH, yoroy's "blue button something you can rely on, you can click it and the form will be submitted/your stuff will be saved" makes sense to me. Let's try it and we can always revisit later if we decide it's overwhelming.

Bojhan’s picture

Bojhan CreditAttribution: Bojhan commented

Agreed, can someone else fix the spaces - I dont know how to get those tabs to show up in my editor

swentel’s picture

swentel CreditAttribution: swentel commented
FileSize
1850182-10.patch5.13 KB
yoroy’s picture

yoroy CreditAttribution: yoroy commented
Status: Needs review » Needs work

Patch needs a bit of cleanup

yoroy’s picture

yoroy CreditAttribution: yoroy commented
Status: Needs work » Needs review

Nice crosspost :)

yoroy’s picture

yoroy CreditAttribution: yoroy commented

None of the primary submits in Field UI are blue. Intentional or oversight?

Bojhan’s picture

Bojhan CreditAttribution: Bojhan commented

Intentional, I think we need to figure out what to do with those two buttons its one of the few places in core we do it and it doesn't have a clear 80% primary button.

yoroy’s picture

yoroy CreditAttribution: yoroy commented
Status: Needs review » Reviewed & tested by the community

I tested the patch and it does what it says it does. I opened #1853260: Which ones of the Field UI submit buttons should be blue? to discuss the special snowflakes that are in Field UI.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Reviewed & tested by the community » Fixed

This looks good to me, fine with tackling Field UI in a follow-up, so I've committed/pushed to 8.x.

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) CreditAttribution: commented
Issue summary: View changes

Updated issue summary.