Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.API page: http://api.drupal.org/api/drupal/core%21modules%21search%21search.pages....
The function initialize the $redirect variable, but that variable is never used from the function, nor is the variable defined as global variable.
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | drupal-remove-variable-1848774-9.patch | 457 bytes | apaderno |
| #3 | drupal-remove-variable-1848774-3.patch | 477 bytes | IshaDakota |
Comments
Comment #1
apadernoI checked the code used from the function in other Drupal versions.
$redirectwas introduced in Drupal 7, but the code has never used that variable, except when initializing it.Comment #2
marcingy CreditAttribution: marcingy commentedTagging as novice
Comment #3
IshaDakota CreditAttribution: IshaDakota commentedLooks like this should have been removed in #497206: Avoid search conflicts with other forms, use menu API instead of search_get_keys().
Comment #5
Berdir#3: drupal-remove-variable-1848774-3.patch queued for re-testing.
Comment #6
apaderno#3: drupal-remove-variable-1848774-3.patch queued for re-testing.
Comment #7
BerdirLooks good.
Comment #8
catchCommitted/pushued to 8.x, thanks!
Comment #9
apadernoThis is the patch for Drupal 7. The same variable that appears in the Drupal 8 code appears in Drupal 7's
search_view().Comment #11
BerdirHow do you always find that stuff? ;) Looks good.
Comment #12
apaderno@Bedir I am the founder of the "Give home to an orphan variable" association.
;-)Comment #13
David_Rothstein CreditAttribution: David_Rothstein commentedCommitted to 7.x - thanks! http://drupalcode.org/project/drupal.git/commit/d5be55f