Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
- TestFieldWidgetMultiple declares no field_type entry in its annotation.
This entry is added in a alter hook, that is used in a test that checks alter hooks are fired.
- However, due to #1780396: Namespaces of disabled modules are registered during test runs, there are cases where the class is found, but not the alter hook
- Therefore, we end up with a widget definition that has no 'field_types' entry.
Bumping to critical, as it seems to raise issues in a couple tested patches - though, not in HEAD, not sure why.
Patch coming up.
Comment | File | Size | Author |
---|---|---|---|
#5 | field_ui_warnings-1848200-5.patch | 1.33 KB | yched |
#1 | field_ui_warnings-1848200-1.patch | 1.32 KB | yched |
Comments
Comment #1
yched CreditAttribution: yched commentedAttached patch :
- Adds an empty 'field_types' entry in TestFieldWidgetMultiple's annotations
- Makes sure an empty 'field_types' entry is always added to discovered definitions (PluginManager::$defaults)
Comment #2
xjmComment #3
BerdirDon't know why HEAD doesn't fail right now either, but this makes sense, is simple and is blocking #1806334: Replace the node listing at /node with a view, #1292470: Convert user pictures to Image Field (both major tasks) and possibly more.
RTBC if it comes back green from the bot.
Comment #4
yched CreditAttribution: yched commentedTestbot didn't report back, but there were fails - http://qa.drupal.org/pifr/test/390698
Looking I'll look into this asap
Comment #5
yched CreditAttribution: yched commentedSo, turns out the annotations reader cannot parse an "empty array" entry and crashes when it meets one.
Opened #1848570: Upgrade to Doctrine\Common 2.4 for that.
So, patch just has the PluginManager make sure the entry is present, which it should.
Added it on formatters too - and removed 'default_value' over there, this has nothing to do here and is a wrong copy/paste from WidgetPluginManager.
Comment #6
yched CreditAttribution: yched commentedComment #7
yched CreditAttribution: yched commentedGreen : http://qa.drupal.org/pifr/test/391128
Comment #8
dawehnerLooking forward to get this patch in, as it blocks pretty much everything related with plugin managers.
Comment #9
catchCommitted/pushed to 8.x, thanks!