Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Right now, the rest entity read/delete tests run on every entity type that it finds.
I think it would be better to limit it to a fixed list of entity types that we want to test. Because it results in unexpected behavior if new entity types are available and the rest tests need to be adjusted for them. They're also slowed down a bit due to that.
The unexpected behavior is limited to config entities provided by the loaded modules, so it's not that bad.
We can still add another entity type explicitly if there's one that is broken and we want to do a regression test.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | rest-tests-1847200-1.patch | 1.95 KB | klausi |
| #1 | rest-tests-1847200-1.patch | 1.95 KB | klausi |
Comments
Comment #1
klausiRight, currently the entity_get_info() is really unpredictable as we are adding other entity types like config entities to core.
Let's hardcode this to entity_test, node and user for now.
Comment #3
klausi#1: rest-tests-1847200-1.patch queued for re-testing.
Comment #4
klausiRe-uploading patch for testbot.
Comment #5
swentel CreditAttribution: swentel commented+1 from me, won't push it RTBC yet, let's at least have one more opinion on this.
Comment #6
BerdirLooks good to me as well.
Comment #7
tim.plunkettOh great, this fixes a bug I hit in #1848964: EntityManager should process its definitions before altering them
+1
Comment #8
das-peter CreditAttribution: das-peter commented+1 from me as well. This causes issues with the new test entity types introduced here #1833334: EntityNG: integrate a dynamic property data table handling.
RESTTestBase::entityCreate()causes an error because it creates the new test entity types in the fallback case and thus doesn't provide required parameters.Comment #9
webchickSeems sensible.
Committed and pushed to 8.x. Thanks!