Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.In system.install for system_update_181() there is an extra ";" that I don't believe is necessary:
$ret[] = update_sql("ALTER TABLE {profile_fields} ADD autocomplete TINYint NOT NULL AFTER visibility ;");
I suggest removing the second to last ";".
The reason why I'm submitting so many of these is because I'm going through the entire 5.2 (will update to 5.3 soon) and making it compatible with SQL Server 2000. Thus, I'm coming across a lot of these things and figured I should share my thoughts. I will submit an overall core patch for SQL Server compatibility soon.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | system_install_1.patch | 648 bytes | hazexp |
| #3 | system_install_0.patch | 648 bytes | hazexp |
Comments
Comment #1
JirkaRybka CreditAttribution: JirkaRybka commentedPatches are (as far as I know) only worth submitting for the -dev versions, and additionally 5.x only accepts bugfixes now.
Otherwise I confirm, that this extra semicolon exists also in 6.x-dev (no wonder, inside an old update), and I consider this a syntax-consistency minor bug (but not changing status, since pcorbett announced a 5.x patch coming).
Comment #2
patchnewbie CreditAttribution: patchnewbie commentedThis would be a great patch for someone new to core development.
Comment #3
hazexp CreditAttribution: hazexp commentedHere's the patch for 5.x-dev
Comment #4
hazexp CreditAttribution: hazexp commentedI've also patched 6.x-dev for the same issue.
Comment #5
JirkaRybka CreditAttribution: JirkaRybka commentedReally simple. Setting RTBC for both patches.
Comment #6
JirkaRybka CreditAttribution: JirkaRybka commentedBut it's for the -dev versions, obviously.
Comment #7
drummCommitted to 5.x.
Comment #8
Gábor HojtsyCommitted to 6.x.
Comment #9
(not verified) CreditAttribution: commentedAutomatically closed -- issue fixed for two weeks with no activity.