When "Highlight retrieved data" checkbox is checked search terms in the returned fulltext fields are wrapped with <strong> tag.
In service.inc there is

<?php
  protected function formatHighlighting($snippet) {
    return preg_replace('#\[(/?)HIGHLIGHT\]#', '<$1strong>', $snippet);
  }
?>

It will be nice to give opportunity to change that hardcoded <strong> tag with some other tags or custom wrapper via settings.

CommentFileSizeAuthor
#3 1845920-3--configurable_highlighting_tags.patch3.03 KBdrunken monkey
#3 1845920-3--configurable_highlighting_tags--interdiff.txt2.24 KBdrunken monkey
#2 1845920-1-configurable-solr-highlight-tags.patch3.79 KBsilverham
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

OanaIlea’s picture

OanaIlea CreditAttribution: OanaIlea at bio.logis Genetic Information Management GmbH commented
Issue summary: View changes
Status: Active » Closed (outdated)

This issue was closed due to lack of activity over a long period of time. If the issue is still acute for you, feel free to reopen it and describe the current state.

silverham’s picture

silverham CreditAttribution: silverham at EY Digital commented
Title: Highlight retrieved data checkbox » Configurable Solr Highlight tags
Status: Closed (outdated) » Needs review
FileSize
1845920-1-configurable-solr-highlight-tags.patch3.79 KB

Attach patch allow configurable highlights on a per solr server basis. Would be good to allow better styling on these.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey as a volunteer commented
FileSize
1845920-3--configurable_highlighting_tags--interdiff.txt2.24 KB
1845920-3--configurable_highlighting_tags.patch3.03 KB

Thanks a lot for the patch! Looks pretty good.
However, I think we can make this both simpler and more performant by just using str_replace() instead of a regex – patch attached.
Please tell me whether this works for you (or you see anything wrong with the code) and I can commit it.

silverham’s picture

silverham CreditAttribution: silverham at EY Digital commented
Status: Needs review » Reviewed & tested by the community

Ah i forgot that str_replace() takes arrays - nice one!

New patch works good for me.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey as a volunteer commented
Status: Reviewed & tested by the community » Fixed

Great to hear, thanks for reporting back!
Committed. Thanks again!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.