Above the field_ui_field_overview() function, there are the following references:

 * @see field_ui_field_overview_form_validate()
 * @see field_ui_field_overview_form_submit()

However, these functions do not exist. Looks like they should be changed to references to Drupal\field_ui\FieldOverview::validate() and Drupal\field_ui\FieldOverview::submit().

CommentFileSizeAuthor
#4 fileuidoc-1845286-4.patch656 bytesPurencool
#2 fileuidoc-1845286-2.patch656 bytesshameemkm
#1 fileuidoc-1845286-#1.patch656 bytesshameemkm
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

shameemkm’s picture

shameemkm CreditAttribution: shameemkm commented
Status: Active » Needs review
FileSize
fileuidoc-1845286-#1.patch656 bytes

Please review.

shameemkm’s picture

shameemkm CreditAttribution: shameemkm commented
FileSize
fileuidoc-1845286-2.patch656 bytes

updating the file name to remove the #.

Purencool’s picture

Purencool CreditAttribution: Purencool commented

Reviewed fileuidoc-1845286-2.patch adds the comments correctly

Purencool’s picture

Purencool CreditAttribution: Purencool commented
FileSize
fileuidoc-1845286-4.patch656 bytes

patch file

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Status: Needs review » Reviewed & tested by the community

Thanks to @shameemkm for working on this in office hours (http://core.drupalofficehours.org/task/1205) congrats on your first patch!
Patch at 4 is same as 2 (no idea why), perhaps impatience with bot?

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.