Convert standard.inc to Drupal\Core\Language

Initial patch.

- standard.inc is now locale.inc
- standard_language_list() is now Language::getStandardLanguageList()

@nick_schuch,

Your above patch is good but missing static definition in function. I have applied the changes in patch, it should now work.

#3: 1845034-2-added-missing-static-defination.patch queued for re-testing.

Again made some minor changes for incorrect locale.inc include & static definition changes.

re-submitting patch file

#8: 1845034-8-resolved-static-defination-and-include-changes.patch queued for re-testing.

#8: 1845034-8-resolved-static-defination-and-include-changes.patch queued for re-testing.

Looks like the last 2 patches weren't saved in UTF-8.

Looks like the last 2 patches weren't saved in UTF-8.

#17: 1845034-14-resolved-static-defination-and-include-changes.patch queued for re-testing.

#17: 1845034-14-resolved-static-defination-and-include-changes.patch queued for re-testing.

I think the original idea behind standard.inc was avoiding to load unnecessary code on every request. The current patch defeats this purpose. What about just making standard.inc an autoloadable Standard class?

Static functions won't cause any performance issues.

That function is used very rarely: loading it on every request seems a waste of memory to me.

You're right the countries could benefit from this though! Where do you think it should go?

Well, Language is singular, hence for consistency I'd go for Drupal\Core\Utility\Country although I recall there was a non irrelevant discussion behind the standard.inc name (not surprisingly :), which in D7 was iso.inc. Not sure whether we want to retain the "standard" terminology somewhere, possibily in the package name.

Yeah, core/lib/Drupal/Core/Language/Language.php is loaded on every page request on every single Drupal 8 site. I'm not sure of the diff of memory use with the added method, if we want to make our code cleaner and take this (small?) penalty, then so be it. Just be aware of it.

If we want to have clean code we can use the Language package: this is what it's there for :)
Sticking every language-related bit of code in the Language class does not look particularly clean to my eyes. In fact #1862202: Objectify the language system is moving the language_list() implementation into the LanguageManager class. If we don't want a dedicated class, then I'd say the language manger is the place.

sounds reasonable to me also.
patch will be like #25 but to those locations proposed in #32. (not quite a novice task, so tagging medium. anyone can tackle making a patch for this)

I see this patch is also updating the script too. #1068840: core/includes/standard.inc contains inaccurate country data good.

Any objections?

No strong ones.

LanguageManager::getLanguageList() will be name of the method used to retrieve the installed language list (see #1862202: Objectify the language system). I'd suggest to rename it to LanguageManager::getStandardLanguageList(). Aside from that looks good to me, thanks.

RTBC If green. Thanks!

@YestCT:

Can you direct someone to the follow-up Rob linked in #35? It should be fairly easy.

@RobLoach:

One last-minute thought: should we instantiate the LanguageManager instead of using a static method? Right now we are hardcoding the implementation instead of relying on the DIC.

#37: 1845034.patch queued for re-testing.

#37: 1845034.patch queued for re-testing.

Now git should be back.

This should fix the fails, but I think we should probably move this into the DIC as suggested in #40.

Will work on it.

+1 on RTBC

Needs a reroll

curl https://drupal.org/files/1845034-language-core-service-49.patch | git a
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 16939  100 16939    0     0  14877      0  0:00:01  0:00:01 --:--:-- 17571
error: patch failed: core/includes/install.core.inc:8
error: core/includes/install.core.inc: patch does not apply

The fail to apply was just around the use XZY; lines in install.core.inc. Easy reroll :) Should only be committed after green of course.

Committed 56f4362 and pushed to 8.x. Thanks!

Woot, thanks!

Added a change notice for this:

https://drupal.org/node/2019333

Updating tags