Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Another easy conversion, this patch moves the cron "page" callback to a controller. It also inlines the access check until #1793520: Add access control mechanism for new router system happens.
Patch coming as soon as I have a nid...
Comment | File | Size | Author |
---|---|---|---|
#4 | 1843844-cron-route.patch | 3.55 KB | Crell |
#1 | 1843844-cron-route.patch | 3.52 KB | Crell |
Comments
Comment #1
Crell CreditAttribution: Crell commentedComment #2
disasm CreditAttribution: disasm commentedI think this was a typo or a statement that was never finished.
Other than that, the patch looks good architecturally. It's nice and simple. The YAML routing file to specify what controller to run, and a direct port of the current cron code to that controller.
Comment #3
Crell CreditAttribution: Crell commentedAyup, I forgot to finish filling that in because I wasn't sure what to say. :-) If you want to reroll with revised text there I can RTBC it. (I won't be able to do so until tonight, so whoever gets to it first, do so.)
Comment #4
Crell CreditAttribution: Crell commentedNew patch, just fixes the doc.
Comment #5
disasm CreditAttribution: disasm commentedComment #6
Crell CreditAttribution: Crell commentedThe denizens of #drupal-contribute suggested making this critical, since it's a procedural blocker for #1793520: Add access control mechanism for new router system, which is also critical. (That issue needs an existing new-style for-reals route to convert, which this issue provides us.)
Comment #7
Dries CreditAttribution: Dries commentedCommitted to 8.x. Glad to see some new routing action. Thanks!