Meta issue: #1843738: [meta] Convert views module to Twig

CommentFileSizeAuthor
#18 1843778-18.patch1.73 KBjoelpittet
#14 views-1843778-10.patch1.71 KBmgifford
#10 views-1843778-10.patch1.71 KBcs_shadow
#5 drupal-views-ui-edit-view--1843778-5.patch1.81 KBsteveoliver
#1 twig-views-ui-edit-view-1843778.patch1.64 KBjoelpittet
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet commented
Status: Active » Needs review
FileSize
twig-views-ui-edit-view-1843778.patch1.64 KB

first draft

mbrett5062’s picture

mbrett5062 CreditAttribution: mbrett5062 commented
Issue tags: +VDC

Tagging.

jpamental’s picture

jpamental CreditAttribution: jpamental commented

Patch applies cleanly, but I'm not having luck finding the right place to see if it's working properly. None of the views edit screens I've tried seems to call this file.

I think this may be ready to call RTBC but want to confirm that it does behave. Anyone with an idea where to test?

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

It's cool that these template conversions lead to removal of files :) That's at least from my perspective another one which is not used at all.

steveoliver’s picture

steveoliver CreditAttribution: steveoliver commented
Title: Convert views/views_ui/theme/views-ui-edit-view.tpl.php to twig » Remove views/views_ui/theme/views-ui-edit-view.tpl.php
Project: » Drupal core
Version: » 8.x-dev
Component: Twig templates conversion (front-end branch) » views_ui.module
FileSize
drupal-views-ui-edit-view--1843778-5.patch1.81 KB

Let's remove this template then?

Moving this issue from the Twig sandbox to Core/views_ui.module.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Reviewed & tested by the community

Awesome!

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Issue tags: +Needs backport to D7

.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Project: Drupal core » Views (for Drupal 7)
Version: 8.x-dev » 7.x-3.x-dev
Component: views_ui.module » Code
Status: Reviewed & tested by the community » Patch (to be ported)

Committed/pushed to 8.x. Moving to Views for backport.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Issue tags: +Novice

Adding novice tag.

cs_shadow’s picture

cs_shadow CreditAttribution: cs_shadow commented
Issue summary: View changes
FileSize
views-1843778-10.patch1.71 KB

Attaching patch for D7.

cs_shadow’s picture

cs_shadow CreditAttribution: cs_shadow commented
Status: Patch (to be ported) » Needs review
mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford commented
Status: Needs review » Reviewed & tested by the community

Applies nicely. Nice to get rid of the unneeded template views-ui-edit-view.tpl.php

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
CreditAttribution: colan at Colan Schwartz Consulting for Chapter Three commented

We've recently switched our testing from the old qa.drupal.org to DrupalCI. Because of a bug in the new system, #2623840: Views (D7) patches not being tested, older patches must be re-uploaded. On re-uploading the patch, please set the status to "Needs Review" so that the test bot will add it to its queue.

If all tests pass, change the Status back to "Reviewed & tested by the community". We'll most likely commit the patch immediately without having to go through another round of peer review.

We apologize for the trouble, and appreciate your patience.

mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford commented
Status: Reviewed & tested by the community » Needs review
FileSize
views-1843778-10.patch1.71 KB

Thanks Colan. This is just for Views patches? D7 patches? Seems broader "Old patches that predate drupalci (Prior to Aug 2015) must be resubmitted."

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
CreditAttribution: colan at Colan Schwartz Consulting for Chapter Three commented

Yes, it's definitely a broader issue.

mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford commented

Annoying.. Thanks!

Chris Matthews’s picture

Chris Matthews CreditAttribution: Chris Matthews as a volunteer commented
Status: Needs review » Needs work
Issue tags: +Needs reroll

The 3 year old patch in #14 to views-ui-edit-view.tpl.php does not apply to the latest views 7.x-3.x-dev and if still relevant needs to be rerolled.

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet as a volunteer and at The University of British Columbia commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
FileSize
1843778-18.patch1.73 KB

Still relevant

Chris Matthews’s picture

Chris Matthews CreditAttribution: Chris Matthews as a volunteer commented
Status: Needs review » Reviewed & tested by the community

All good, thanks Joël.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Parent issue: » #2960871: Plan for Views 7.x-3.23 release
renatog’s picture

renatog
Location Campinas
CreditAttribution: renatog at CI&T commented

Really makes sense.

+1 to it

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Reviewed & tested by the community » Fixed

Committed. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.