Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Meta issue: #1843738: [meta] Convert views module to Twig
Comment | File | Size | Author |
---|---|---|---|
#16 | drupal-views-ui-edit-item--1843776-11.patch | 1.92 KB | star-szr |
| |||
#15 | drupal-views-ui-edit-item--1843776-15.patch | 1.36 KB | sdstyles |
| |||
#11 | drupal-views-ui-edit-item--1843776-11.patch | 1.92 KB | Pete B |
#5 | drupal-views-ui-edit-item--1843776-5.patch | 2.09 KB | steveoliver |
#1 | twig-views-ui-edit-item-1843776.patch | 1.17 KB | joelpittet |
Comments
Comment #1
joelpittetfirst draft
Comment #2
mbrett5062 CreditAttribution: mbrett5062 commentedTagging.
Comment #3
jpamental CreditAttribution: jpamental commentedApplies cleanly, but not finding a way to test them (even putting in debug code)
Any specific URL's to test and see?
Comment #4
dawehnerYeah this template actually is not used in d7 or d8 at all.
Comment #5
steveoliver CreditAttribution: steveoliver commentedComment #6
dawehnertested manually to be sure.
Comment #7
Dries CreditAttribution: Dries commentedCommitted to 8.x. Thanks.
Comment #8
dawehnerhey :)
Comment #10
star-szrReopening for the backport.
Comment #11
Pete B CreditAttribution: Pete B commented7.x backport
Comment #12
dawehnerNice!
Comment #13
colanWe've recently switched our testing from the old qa.drupal.org to DrupalCI. Because of a bug in the new system, #2623840: Views (D7) patches not being tested, older patches must be re-uploaded. On re-uploading the patch, please set the status to "Needs Review" so that the test bot will add it to its queue.
If all tests pass, change the Status back to "Reviewed & tested by the community". We'll most likely commit the patch immediately without having to go through another round of peer review.
We apologize for the trouble, and appreciate your patience.
Comment #14
star-szrThanks @colan! Just putting back to needs work for the task of re-uploading the patch.
Comment #15
sdstyles CreditAttribution: sdstyles at FFW commentedDeleted file, created patch again.
Comment #16
star-szr@sdstyles thanks but it wasn't necessary to recreate the patch and it's now missing a hunk (the views_ui_theme() changes). Re-uploading the patch from #11 because it applies fine.
Comment #18
sdstyles CreditAttribution: sdstyles at FFW commentedComment #19
joelpittetBack to RTBC from #12
Comment #21
DamienMcKennaCommitted. Thanks.