Meta issue: #1843738: [meta] Convert views module to Twig

CommentFileSizeAuthor
#16 drupal-views-ui-edit-item--1843776-11.patch1.92 KBstar-szr
#15 drupal-views-ui-edit-item--1843776-15.patch1.36 KBsdstyles
#11 drupal-views-ui-edit-item--1843776-11.patch1.92 KBPete B
#5 drupal-views-ui-edit-item--1843776-5.patch2.09 KBsteveoliver
#1 twig-views-ui-edit-item-1843776.patch1.17 KBjoelpittet
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet commented
Status: Active » Needs review
FileSize
twig-views-ui-edit-item-1843776.patch1.17 KB

first draft

mbrett5062’s picture

mbrett5062 CreditAttribution: mbrett5062 commented
Issue tags: +VDC

Tagging.

jpamental’s picture

jpamental CreditAttribution: jpamental commented

Applies cleanly, but not finding a way to test them (even putting in debug code)

Any specific URL's to test and see?

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

Yeah this template actually is not used in d7 or d8 at all.

steveoliver’s picture

steveoliver CreditAttribution: steveoliver commented
Title: Convert views/views_ui/theme/views-ui-edit-item.tpl.php to twig » Remove unused template views-ui-edit-item.tpl.php
Project: » Drupal core
Version: » 8.x-dev
Component: Twig templates conversion (front-end branch) » views_ui.module
FileSize
drupal-views-ui-edit-item--1843776-5.patch2.09 KB
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs backport to D7

tested manually to be sure.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed
Issue tags: -Needs backport to D7

Committed to 8.x. Thanks.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Project: Drupal core » Views (for Drupal 7)
Version: 8.x-dev » 7.x-3.x-dev
Component: views_ui.module » User interface
Issue tags: +Novice, +Needs backport to D7

hey :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

star-szr’s picture

star-szr
he/him
Primary language English
CreditAttribution: star-szr commented
Status: Closed (fixed) » Patch (to be ported)

Reopening for the backport.

Pete B’s picture

Pete B CreditAttribution: Pete B commented
Status: Patch (to be ported) » Needs review
FileSize
drupal-views-ui-edit-item--1843776-11.patch1.92 KB

7.x backport

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Reviewed & tested by the community

Nice!

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
CreditAttribution: colan at Colan Schwartz Consulting for Chapter Three commented
Issue summary: View changes

We've recently switched our testing from the old qa.drupal.org to DrupalCI. Because of a bug in the new system, #2623840: Views (D7) patches not being tested, older patches must be re-uploaded. On re-uploading the patch, please set the status to "Needs Review" so that the test bot will add it to its queue.

If all tests pass, change the Status back to "Reviewed & tested by the community". We'll most likely commit the patch immediately without having to go through another round of peer review.

We apologize for the trouble, and appreciate your patience.

star-szr’s picture

star-szr
he/him
Primary language English
CreditAttribution: star-szr as a volunteer and at Northern Commerce commented
Status: Reviewed & tested by the community » Needs work

Thanks @colan! Just putting back to needs work for the task of re-uploading the patch.

sdstyles’s picture

sdstyles CreditAttribution: sdstyles at FFW commented
Status: Needs work » Needs review
FileSize
drupal-views-ui-edit-item--1843776-15.patch1.36 KB

Deleted file, created patch again.

star-szr’s picture

star-szr
he/him
Primary language English
CreditAttribution: star-szr as a volunteer commented
FileSize
drupal-views-ui-edit-item--1843776-11.patch1.92 KB

@sdstyles thanks but it wasn't necessary to recreate the patch and it's now missing a hunk (the views_ui_theme() changes). Re-uploading the patch from #11 because it applies fine.

Status: Needs review » Needs work

The last submitted patch, 16: drupal-views-ui-edit-item--1843776-11.patch, failed testing.

sdstyles’s picture

sdstyles CreditAttribution: sdstyles at FFW commented
Status: Needs work » Needs review
joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet as a volunteer commented
Status: Needs review » Reviewed & tested by the community

Back to RTBC from #12

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Reviewed & tested by the community » Fixed
Parent issue: » #2855120: Plan for Views 7.x-3.16 release

Committed. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.