Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 UTC on 18 March 2024, to get $100 off your ticket.
Due to the moving around of a lot of code, something happened and a submit handler got lost.
Additional some form['#actions'] exist two times.
Comment | File | Size | Author |
---|---|---|---|
#8 | interdiff.txt | 2.27 KB | tim.plunkett |
#8 | vdc-1841442-8-FAIL.patch | 3.2 KB | tim.plunkett |
#8 | vdc-1841442-8-PASS.patch | 5.85 KB | tim.plunkett |
#7 | 1841442-7.patch | 5.85 KB | damiankloip |
#6 | 1841442-6.patch | 5.88 KB | damiankloip |
Comments
Comment #1
dawehnerThis is the only change i'm not sure why it's needed, even $form_state['values'] is filled on the rebuild request,
it doesn't work as expect, so we maybe need investigation.
Comment #2
dawehnerFinally figured it out.
Comment #3
damiankloip CreditAttribution: damiankloip commentedHere are some quick tests to show this failing and passing with the Daniel's fix.
Comment #4
dawehnerwe never c&p in tests, we never do :)
No need for that, the UITestBase does this for us.
Comment #5
damiankloip CreditAttribution: damiankloip commentedThe tests and the correct patch containing the fix...
Comment #6
damiankloip CreditAttribution: damiankloip commentedAnd with the comments from #4! :)
Comment #7
damiankloip CreditAttribution: damiankloip commentedWe don't need the $edit_url variable now either. Sorry for the issue noise.
Comment #8
tim.plunkettI've cleaned up the docs and coding style, but this indeed was a bug of my creation :(
The tests look good, just double checking.
Comment #9
catchLooks good, comes with nice test coverage. Committed/pushed to 8.x.