drupal_set_message allows 'warning' as a parameter for $type. Reflecting this in the comments.

CommentFileSizeAuthor
#2 setmessage2.patch597 bytesalpritt
setmessage.patch599 bytesalpritt
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Needs review » Needs work

That's great, thanks!!

The one improvement I would make is put them in order of severity. So notice first, then warning, then error.

alpritt’s picture

alpritt CreditAttribution: alpritt commented
Status: Needs work » Needs review
FileSize
setmessage2.patch597 bytes

reordered.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Needs review » Reviewed & tested by the community

Looks great to me! RTBC. :)

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Anonymous’s picture

(not verified) CreditAttribution: commented
Status: Fixed » Closed (fixed)