this confirms my suspicion that nobody spends any time in comment.module... ;)

attached uses the proper FAPI syntax for returning a redirect.

patch is for D6, but this needs to be fixed in D5 as well...

marking as critical, because this breaks an important project module bugfix.

CommentFileSizeAuthor
#4 comment_return_d6_0.patch624 byteshunmonk
#1 comment_return_d5.patch617 byteshunmonk
comment_return_d6.patch605 byteshunmonk
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

hunmonk’s picture

hunmonk CreditAttribution: hunmonk commented
FileSize
comment_return_d5.patch617 bytes

patch for D5.

dmitrig01’s picture

dmitrig01 CreditAttribution: dmitrig01 commented

Drupal 5 looks good, but in Drupal 6, we set $form_state['redirect'], and we don't return anything

dmitrig01’s picture

dmitrig01 CreditAttribution: dmitrig01 commented
Status: Needs review » Needs work
hunmonk’s picture

hunmonk CreditAttribution: hunmonk commented
Status: Needs work » Needs review
FileSize
comment_return_d6_0.patch624 bytes

good catch. here's the correct patch for D6.

dww’s picture

dww
we/he/they
CreditAttribution: dww commented
Status: Needs review » Reviewed & tested by the community

#1 for DRUPAL-5 and #4 for HEAD are both RTBC. Not sure I agree this is critical, but I'll leave that alone... ;) It is important for project.module, so it should definitely go in ASAP, thanks.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Version: 6.x-dev » 5.x-dev

Thanks, committed to Drupal 6.x.

drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm commented
Status: Reviewed & tested by the community » Fixed

Committed to 5.x.

Anonymous’s picture

(not verified) CreditAttribution: commented
Status: Fixed » Closed (fixed)