Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.For example node_views_query_substitutions is placed into node.views.inc, so it will not be loaded under certain cases
and so actual sql code might be broken.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | 1828612-followup-7.patch | 999 bytes | David_Rothstein |
| #4 | drupal-1828612-4.patch | 7.43 KB | dawehner |
| #2 | durpal-1828612-2.patch | 7.79 KB | dawehner |
| #1 | 1828612.patch | 561 bytes | damiankloip |
Comments
Comment #1
damiankloip CreditAttribution: damiankloip commentedComment #2
dawehnerIt's too later to figure out the test failures
Comment #4
dawehnerNever write tests at night.
Comment #5
tim.plunkettThis can easily cause Views to break, and the fix and tests are exactly right.
Comment #6
webchickCommitted and pushed to 8.x. Thanks!
Comment #7
David_Rothstein CreditAttribution: David_Rothstein commentedFor some reason, the commit for this issue made weird changes to default.settings.php (even though they weren't in the above patch). It introduced some grammatical mistakes and rolled back #1830330: Make default.settings.php not executable... I think what happened is that it actually rolled back the last couple commits on that file, or something?
See: http://drupalcode.org/project/drupal.git/blobdiff/e318f1a6df45e135fdaf67...
The attached patch restores those.
Comment #8
catch#7: 1828612-followup-7.patch queued for re-testing.
Comment #9
catchCommitted/pushed the follow-up. The permissions had been fixed already but the docs changes still applied. Thanks!