phpCAS 1.3.0 and later no longer accepts the $format parameter for phpCAS::setPGTStorageFile($path).

See the following commits to phpCAS for the origin of this phpCAS API change:
https://github.com/Jasig/phpCAS/commit/1307361d06fe6b1236e2041a5e37480f5...
https://github.com/Jasig/phpCAS/commit/a0ab15965c4fdb8a247fad5553cce4d01...

Repeatable: Always
Steps to repeat:
1. Use the CAS module with phpCAS 1.3 or later
2. Configure the CAS module to authenticate as a proxy.
3. Try to log in - the $format will be passed as the first argument when phpCAS 1.3 is expecting the $path to be the first argument, resulting in an error.

CommentFileSizeAuthor
#1 cas-setPGTStorageFile-1827482-1.patch1.95 KBadamfranco
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

adamfranco’s picture

adamfranco CreditAttribution: adamfranco commented
FileSize
cas-setPGTStorageFile-1827482-1.patch1.95 KB

Here is a patch which fixes this issue. It uses version_compare() on PHPCAS_VERSION which isn't super elegant, but that seems more straight forward that getting into reflection for testing the number of allowed parameters to the function.

adamfranco’s picture

adamfranco CreditAttribution: adamfranco commented
Status: Active » Needs review
bfroehle’s picture

bfroehle CreditAttribution: bfroehle commented
Version: 7.x-1.x-dev » 6.x-3.x-dev
Status: Needs review » Patch (to be ported)

Committed #1 to 7.x-1.x. Needs backport to 6.x-3.x-dev. Thanks.

bfroehle’s picture

bfroehle CreditAttribution: bfroehle commented
Status: Patch (to be ported) » Fixed

Committed to 6.x-3.x. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit f62b038 on 7.x-1.x, 8.x-1.x authored by adamfranco, committed by bfroehle: 
    Issue #1827482: phpCAS::setPGTStorageFile() no longer accepts the $...