Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
All the hook_views_analyze implementations are existing in the $module.views.inc files so they are only executed
once the file is load.
Proposed resolution
Add hook_views_analyze into hook_hook_info.
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | drupal-1827286-9.patch | 6.68 KB | damiankloip |
| #8 | drupal-1827286-8.patch | 6.54 KB | dawehner |
| #1 | drupal-1827286-1-test.patch | 1.99 KB | dawehner |
| #1 | drupal-1827286-1.patch | 6.53 KB | dawehner |
Comments
Comment #1
dawehnerThis adds a test, and shows that the node implementation is broken.
Let's fix it.
Comment #2
aspilicious CreditAttribution: aspilicious commentedOk nice :)
Comment #3
tim.plunkett#1: drupal-1827286-1.patch queued for re-testing.
Comment #5
dawehner#1: drupal-1827286-1.patch queued for re-testing.
Comment #6
dawehner#1: drupal-1827286-1-test.patch queued for re-testing.
Comment #8
dawehnerRerolled against the new protected properties on the View Entity.
Comment #9
damiankloip CreditAttribution: damiankloip commentedRe rolled and just added a docblock for views_test_data.views.inc.
I think this is looking fine. I guess the only other implementation is in views_ui.module so it works. I guess we could move that too if we wanted to?
Comment #10
dawehnerYeah let's fill a novice task to move this function to views.views.inc or even views_ui.views.inc
Comment #11
catchCommitted/pushed to 8.x, thanks!