Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
Currently Views has a specific style sheet for each core theme. Some of the styles are needed for Views, and others duplicate styles that are already produced by the theme.
Proposed resolution
Merge the Views custom styles into to the actual core themes.
Remaining tasks
- Each Views custom theme sheet should be added to its respective theme's CSS
- After styles have been included with their theme, remove the custom sheets from Views
- Refactor the added Views styles accordingly, with special attention paid to style duplication
User interface changes
n/a
API changes
n/a
Comment | File | Size | Author |
---|---|---|---|
#9 | vdc-1826574-9.patch | 24.21 KB | tim.plunkett |
#9 | interdiff.txt | 530 bytes | tim.plunkett |
#8 | vdc-1826574-6-formatpatch.patch | 29.78 KB | dead_arm |
#8 | vdc-1826574-6.patch | 24.1 KB | dead_arm |
#6 | durpal-1826574-6.patch | 30.23 KB | dawehner |
Comments
Comment #1
dead_armWorking on an issue summary.
Comment #2
yoroy CreditAttribution: yoroy commentedThis will help resolve #1806022: Views' text color does not have sufficient contrast which is a critical. Go for it :)
Comment #3
dead_armHere's a preliminary patch. Leaving assigned to myself to remove further redundancies.
Comment #4
dawehnerGreat work!
We could remove some php code if we move the css files, awesome.
Comment #6
dawehnerRerolled against tim :p
Comment #7
tim.plunkettAll of this code should go away; there is no reason we should assume that non-core themes are used.
Comment #8
dead_armOkay, here's the whole thing, one as a format patch for readability, and one as a regular patch.
Comment #9
tim.plunkettThis is holding up a critical (#1806022: Views' text color does not have sufficient contrast), so it shouldn't be a normal task.
There were only two visual changes lost in that patch, I've added them back. Otherwise, as this was fully manually tested, it's ready to go.
Comment #11
dawehner#9: vdc-1826574-9.patch queued for re-testing.
Comment #13
webchickThat's definitely a bit silly. Also, CSS patches don't tend to fail Drupal installation. ;)
Committed to 8.x. Will rebase and push when I'm done with the current commit spree.
Comment #14
tim.plunkettApparently this wasn't fully tested with the changes in #723392: Tame seven's reset.css, and effectively conflicted.
Comment #15
tim.plunkettApparently this was fixed somewhere else, I can no longer reproduce.
Comment #16.0
(not verified) CreditAttribution: commentedUpdate issue summary.