Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
When adding a view, a blind user can see "fields", "sort criteria", "filter criteria" and similar titles as headings. But, unfortunately, the related operations are shown before the headings, not after them. This is really confusing for new views user (it was one of my main issues with views) and increases very much the learning curve for new blind users.
Just to clarify, let me give an example of the structure that I would like to see (related to sort criteria):
- The "sort criteria" heading;
- The sort criteria that a view is currently using;
- The dropbutton to add a new sort criteria
Comment | File | Size | Author |
---|---|---|---|
#35 | views-dropbutton_D7-1826368-35.patch | 646 bytes | Andrew Answer |
| |||
#31 | SortOrder.png | 257.89 KB | mgifford |
#20 | dropbuttond7port-after.png | 19.62 KB | IshaDakota |
#20 | dropbuttond7port-before.png | 19.88 KB | IshaDakota |
#19 | views-dropbutton-d7port-1826368-19.patch | 672 bytes | IshaDakota |
Comments
Comment #1
falcon03 CreditAttribution: falcon03 commentedCorrecting title.
Comment #2
dawehnerCompared to #1824634: [meta] Dropbutton accessibility issues this should be normal
Comment #3
Bojhan CreditAttribution: Bojhan commentedIsnt this like a novice task?
This one is borderline major, I actually did the whole NVDA thing with your eyes closed. And this one is really confusing.
Comment #4
larowlanStraight forward re-ordering of markup, screenshots attached.
Before
After
Comment #5
CBLooks good. Patch applied and screen read with VoiceOver.
Comment #6
larowlanworks ok in voiceover/chrome/osx now
Comment #7
larowlancross post
Comment #8
dawehnerNice work!
Comment #9
webchickCommitted and pushed to 8.x. Rock!
Comment #10
falcon03 CreditAttribution: falcon03 commentedSorry, I haven't had time to test the patch these days, I've been able to test it only today.
Things are better now. But I think that things related to the dropbutton should be placed between the heading and the dropbutton itself.
For instance, for the "sort criteria" the structure should be the one described in the issue summary. Actually, instead, it is as follows:
I am re-opening this issue; I don't know if this should be a follow up.
Comment #11
mgiffordHopefully we can sort through this in the issue and make a revision.
Comment #12
Yoshi CreditAttribution: Yoshi commentedMoved the $content above the $actions. Seems to work.
Comment #13
dawehnerThis looks good from the code site, but i'm wondering whether the visual output changes with that change? Maybe someone
should just post a screenshot.
Comment #14
falcon03 CreditAttribution: falcon03 commentedFrom the accessibility point of view it's perfect now. RTBC for me, but I am not changing the status due to dawehner request.
BTW: With the two small fixes in this issue we made two very big improvements to views accessibility! The placement of operations was really difficult to understand for new views blind users...
Comment #15
dawehnerSo there is no visual difference before and after this change, it looks perfect!
Before
After
Comment #16
Dries CreditAttribution: Dries commentedThanks! Committed to 8.x.
Comment #17
dawehnerLet's backport that.
Comment #18
IshaDakota CreditAttribution: IshaDakota commentedpatch for backport to D7
Comment #19
IshaDakota CreditAttribution: IshaDakota commentedoops, whitespace removed.
Comment #20
IshaDakota CreditAttribution: IshaDakota commentedScreenshot before patch applied:
Screenshot after patch applied:
Appears visually unaltered.
Comment #21
dawehnerThat is looking great!
Comment #22
falcon03 CreditAttribution: falcon03 commentedGuys, I don't know what happened. We have a problem: I don't know the reason why, but the situation at this time is the same as in #10...
I am sorry this issue is becoming confused, but I thought I'd better report the problem here.
Comment #23
dawehnerWell i have no clue why, but the HTML is fine.
Comment #24
mgifford#19: views-dropbutton-d7port-1826368-19.patch queued for re-testing.
Comment #26
shnark CreditAttribution: shnark commentedI looked for the file mentioned in #12, that it sounds like Dries committed in #16.
It looks like it should have been in this file core/modules/views/views_ui/theme/views-ui-display-tab-bucket.tpl.php.
but, there is no theme directory in views_ui.
Where is this file now?
Comment #27
tim.plunkettIt was moved in #1805980: Rename /theme to /templates and theme.inc to views.theme.inc to core/modules/views/views_ui/templates/views-ui-display-tab-bucket.tpl.php
Comment #28
mgifford@EllaTheHarpy are you able to reroll a new patch?
Comment #29
mgiffordI think the patch from #19 got it into core. From core/modules/views/views_ui/templates/views-ui-display-tab-bucket.tpl.php the HTML now looks like:
Now whether it is working properly or not is another issue, but it should be in the right order now.
Comment #30
dawehnerSo this should be marked as fixed?
Comment #31
mgiffordYes, it seems to be. Attached a screenshot. HTML looks good. VoiceOver approaches this in the right order.
Comment #32
IshaDakota CreditAttribution: IshaDakota commentedThe patch in #19 was a backport against Views-7.x-3.x. The patch in #12 was committed to core.
Changing the project and status in case backport is still needed/wanted.
Comment #33
IshaDakota CreditAttribution: IshaDakota commented#19: views-dropbutton-d7port-1826368-19.patch queued for re-testing.
Comment #34
Chris Matthews CreditAttribution: Chris Matthews as a volunteer commentedThe 6 year old patch in #19 to views-ui-display-tab-bucket.tpl.php does not apply to the latest views 7.x-3.x-dev and if still applicable needs to be rerolled.
Comment #35
Andrew Answer CreditAttribution: Andrew Answer as a volunteer commentedPatch rerolled.