API functions shouldn't do a dsm. I have some SimpleTests running that create and delete a ton of users and the messages scroll forever. I just moved the dsm to the single user delete. I left it out of user_multiple_delete_confirm_submit cuz I don't think it belongs there.

CommentFileSizeAuthor
#1 user.msg_.patch1.44 KBRobRoy
user.module_76.patch1.04 KBRobRoy
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

RobRoy’s picture

RobRoy CreditAttribution: RobRoy commented
Title: user_delete shouldn't set a message » Set '%name has been deleted.' message in _submit, not in user_delete()
Version: 5.2 » 7.x-dev
FileSize
user.msg_.patch1.44 KB

Here's a patch rolled against HEAD.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented
Version: 7.x-dev » 6.x-dev
Status: Needs review » Reviewed & tested by the community

Simple patch, works as advertised. Not really an API change, but a small bug fix, hence marking for D6.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented
Title: Set '%name has been deleted.' message in _submit, not in user_delete() » Message in _submit(), not in user_delete()

Better title.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Reviewed & tested by the community » Fixed

Thanks, committed.

Anonymous’s picture

(not verified) CreditAttribution: commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.