Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.This is a sub-task of http://drupal.org/node/1775842 Convert all variables to state and/or config systems.
| Comment | File | Size | Author |
|---|---|---|---|
| #23 | 1824898-weight_select_max_to_config-drupal8-23.patch | 420 bytes | vijaycs85 |
| #21 | 1824898-weight_select_max_to_config-drupal8-21.patch | 651 bytes | vijaycs85 |
| #18 | 1824898-weight_select_max_to_config-drupal8-18.patch | 651 bytes | ACF |
| #12 | 1824898-drupal_weight_select_max-cmi-12.patch | 2.06 KB | ACF |
| #10 | 1824898-drupal_weight_select_max-cmi-10.patch | 1.57 KB | ACF |
Comments
Comment #1
vijaycs85Comment #2
vijaycs85Comment #4
vijaycs85#1: 1824898-drupal_weight_select_max-cmi-1.patch queued for re-testing.
Comment #5
alexpottdrupal_weight_select_max should be configuration and not state. So we to add this to system.site.yml etc..
Comment #6
vijaycs85Thanks for the review Alex. Just changed it as config.
Comment #7
vijaycs85Missed to change the upgrade hook. Here is the fixed one.
Comment #9
alexpottThe failures are due to an issue with
update_variables_to_config(). This is now postposed on #1825466: Allow NestedArray::mergeDeepArray() to preserve integer keysComment #10
ACF CreditAttribution: ACF commentedreroll of the patch by vijaycs85, Not sure about the naming of the variable weight_select_max, wonder if it could be something a bit more descriptive.
Comment #11
longwaveconfig(system.site)is missing quotes.The DRUPAL_WEIGHT_SELECT_MAX constant is now redundant and can be deleted as well.
Comment #12
ACF CreditAttribution: ACF commentedTry again, silly mistake.
Comment #13
gddLooks good to me if the bot comes back green
Comment #14
webchickCommitted and pushed to 8.x. Thanks!
Comment #15
swentel CreditAttribution: swentel commentedI think more was pushed than intented, see http://drupalcode.org/project/drupal.git/commit/cd8dd17
Comment #16
yched CreditAttribution: yched commentedYup, some EFQ code got in as well in the same commit :-)
Comment #17
catchRolled this back so we can get a cleaner commit history. Also there's a conflict with the update functions so it'll need a re-roll.
Comment #18
ACF CreditAttribution: ACF commentedUpdated the system.install.
Comment #19
aspilicious CreditAttribution: aspilicious commented#18: 1824898-weight_select_max_to_config-drupal8-18.patch queued for re-testing.
Comment #21
vijaycs85re-rolling with update_N
Comment #22
ACF CreditAttribution: ACF commentedI think that it is easier rather than always updating the system.install update number to just add the variable it to another system.site update, partiularly as that is what is going to happen eventually anyway.
Comment #23
vijaycs85I'm happy to do it :)
Comment #24
aspilicious CreditAttribution: aspilicious commentedI'm confused are the actual .yml changes already comitted? According to catch it seems everything is reverted. So we have to recreate the patch.
Comment #25
vijaycs85yeah, except hook_update_N, other changes in patch at #12 is already in core.
Comment #26
aspilicious CreditAttribution: aspilicious commentedOk lets go for it than :)
Comment #27
webchickCommitted and pushed to 8.x. Thanks!
Hopefully I didn't screw it up this time. ;)
Comment #29
vijaycs85Comment #30
sunThis conversion doesn't really make sense (in any way).
Created #2264177: Replace misplaced system.site:weight_select_max config setting with form element #property