Indentation in /core/modules/comment/lib/Drupal/comment/Plugin/views/row/Rss.php is incorrect

Dec. 1. :) Thanks @larowlan.

Found indentation and fixed.

To avoid introducing needless conflicts with functional patches that can't be committed, we're postponing all coding standards patches until after December 1st: #1805996-54: [META] Views in Drupal Core

Rss.php file location has changed Patch needed re-roll

+1 for coding standards fixes!

Please, can we replace these PHP4-style var declarations with public, and add docblocks? It seems a bit much to fix the indentation of undocumented and old declarations.

Let's mark this as novice task.

Updated. Please check

Thank you for the patch!

+++ b/core/modules/comment/src/Plugin/views/row/Rss.php
@@ -24,8 +24,8 @@
+  public $base_table = 'comment';
+  public $base_field = 'cid';

They could be protected.

Hey, based on dawehner's feedback I have changed them to protected.

Patch and interdiff are attached.
This is my second contribution to Drupal core :-)

Thanks for incorporating #14! Looks good to go :)

+++ b/core/modules/comment/src/Plugin/views/row/Rss.php
@@ -24,8 +24,8 @@
-   var $base_table = 'comment';
-   var $base_field = 'cid';
+  protected $base_table = 'comment';
+  protected $base_field = 'cid';

If we are fixing this we should be making the property declaration completely comply with coding standards.

@Alex: I was contemplating whether to ask to do that, I figured it wasn't worth it; I figured wrong :) Sorry about that.

One question - Where are these two properties being used ? I mean, these are not used anywhere in RSS.php.

@joshi.rohit100
I'm a bit confused as to what the intentions of the variables $base_table, $base_field, and $entityTypeId are.
The variables were previously changed by myself from public to protected at the request of @dawehner.

Being that these variables are now protected, they will only be available from classes that extend the Rss class.
In a Terminal window I ran grep -nriI "extends Rss" *, in an attempt to find other files that extend the Rss class, and therefore would be able to use the variables. A screenshot is attached, but as far as I can tell there are no other files that would be able to use the variables. (also there are no other instances of the variables in the Rss.php file). Which leads me to believe the variables aren't being used at all?

I'm not really sure where to go from here, this is getting a bit out of my depth. Perhaps the variables needed to be left as public so they can be used? I'll let someone who knows more about this take over from here :-)

Should the doc be like this?

For this limited amount of scope, its the right way. Later, if someone thinks its worth, we could cameCase them.

I added a beta phase evaluation to the issue summary.

Lookin' good!

Committed and pushed to 8.0.x. Thanks!