It would be good if we started to add more token support for core tokens. With the hope of using this more widely throughout views.

Here is an initial patch to get thing started. Adds new tokens for result count, base table, and base field.

CommentFileSizeAuthor
#5 1817938-5.patch3.83 KBdamiankloip
#3 1817938-3.patch3.15 KBdamiankloip
#2 1817938-2.patch2.26 KBdamiankloip
views-additional-tokens.patch2.18 KBdamiankloip
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented 
+++ b/lib/Drupal/views/Tests/TokenReplaceTest.phpundefined
@@ -32,6 +32,7 @@ class TokenReplaceTest extends ViewTestBase {
     $view->setDisplay('page_1');
+    $view->execute();

Better use $this->executeView($view);

A random suggestion, what about adding the total items if available?

damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented
FileSize
1817938-2.patch2.26 KB

Good point.

damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented
FileSize
1817938-3.patch3.15 KB

With a couple more tokens...

Status: Needs review » Needs work

The last submitted patch, 1817938-3.patch, failed testing.

damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented
Status: Needs work » Needs review
FileSize
1817938-5.patch3.83 KB

Forgot to add the changes to the yml file to the patch. Also, I realised if the the items per page is 0 we would set this to 1 for the division.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Reviewed & tested by the community

This looks good now

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Reviewed & tested by the community » Fixed

http://drupalcode.org/project/views.git/commit/f25472c

Automatically closed -- issue fixed for 2 weeks with no activity.