Add descriptions to clarify "administer users" and "administer user settings" permissions

Over in #366950-64: "Administer Users" permission should be separate from "Administer Account Settings" I proposed:

Administer users
Manage all user accounts. This includes editing all user information, including e-mail addresses and passwords, issuing e-mails to users and blocking and deleting user accounts.

Administer user settings
Manager user settings, such as the registration and cancellation methods, the text of user e-mails, and fields attached to users.

Attaching patch (currently includes permissions adding too as well as descriptions) and screenshot with how it looks on permissions page.

Oh looks we need to wait until #366950 get committed.

The attached patch changes the description for the "Administer users" and "Administer account settings" using the text from the first comment.

Also, take note that "Administer user settings" is now "Administer account settings".

#5: user_permission_descriptions-1813488-5.patch queued for re-testing.

Thanks, that looks great. Sadly, I had a typo in my suggestion above :-/

+++ b/core/modules/user/user.module
@@ -478,11 +478,12 @@ function user_permission() {
+      'description' => t('Manager <a href="@url">user settings</a>, such as the registration and cancellation methods, the text of user e-mails, and fields attached to users.', array('@url' => url('admin/config/people'))),

Manager -> Manage

Not a problem. :) Patch fixes typo.

Thanks, looks great!

New patch changes url() to \Drupal::url and @ to ! in placeholders.

For some reason, using \Drupal::url() throws exception in 2 Views tests:

Drupal\Core\Database\DatabaseExceptionWrapper: SQLSTATE[42S02]: Base table or view not found: 1146 Table 'drupaltestbotmysql.simpletest667529router' doesn't exist

, so generated URL by calling \Drupal::urlGenerator()->generateFromPath() . Or any ideas how to fix problems with Views tests? Link...

I have the same problem. Any ideas?

16: user_permission_descriptions-1813488-16.patch queued for re-testing.

Hi,

I've tried to review this issue but as the patch is very old (2013), far away from the beta1, i saw that hook_permissions no longer exist in the API so the patch will not be valid at all now (maybe i'm wrong).

I saw that definition of permissions moved to a yml file

Also the name of permission administer users and administer users settings move to administer users and Administer account settings i guess.

So work will be do on that initial need, maybe create a new patch from the yml file with the descriptions from the older patch.

Sorry if i missunderstood something, i'm a beginner in drupal contribution :)

I've rerolled the patch.

Nice, works for me.

Before:

After applying patch:

Just the upload for one of the images above

Restoring the amsterdam2014 tag for historic analytics purposes.

I reviewed this propositions and have some suggestions about text descriptions.

Administer users
Manage all user accounts. This includes editing all user information, changes of e-mail addresses and passwords, issuing e-mails to users, blocking and deleting user accounts.

My comment: Small styling changes.

Administer account settings
Configure site-wide settings and behavior for user accounts and registration. This includes account cancellation methods, the content of user e-mails and fields attached to users.

My comment: Here, for me, the most important think is that this settings and behaviurs are user account site-wide settings. This has been removed in changed comment and I restored it im my proposition. This may be obvious for someone, who used Drupal, but for novice I think this is good to stay with 'site-wide' information.

I've attached patch with this changes.

+1 From me. From technical perspective it's only update of single .yml file.

Description is clear enough.

+++ b/core/modules/user/user.permissions.yml
@@ -3,10 +3,11 @@ administer permissions:
+  description: 'Manage all user accounts. This includes editing all user information, changes of e-mail addresses and passwords, issuing e-mails to users, blocking and deleting user accounts.'

I think this should be Manage all user accounts. This includes editing all user information, changes of e-mail addresses and passwords, issuing e-mails to users and blocking and deleting user accounts. Since "issuing e-mails to users" and "blocking and deleting user accounts" are the separate list items and we don't use the Oxford comma.

I agree with ngwebs that using "site-wide" is a better option.

Here's the patch without the oxford comma and the interdiff (my first)

And, since I'm into screenshots at the moment.

Patch #1813488-32: Add descriptions to clarify "administer users" and "administer user settings" permissions includes suggestions from #1813488-31: Add descriptions to clarify "administer users" and "administer user settings" permissions and can be committed.

Committed 5a53811 and pushed to 8.0.x. Thanks!