Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
We have provision_drupal_sync_site() but no provision_drupal_sync_site_BACK()
The file platform/backup.provision.inc does does have some code to sync back all remote changes from a site.
Which I would like to generalize.
I'm hoping such changes will improve the overall code quality of provision and make changes such as #1205458: Move modules/themes/libraries/files/private directories out of /sites/example.com and #1083366: Make the spokes authoritative for files/ and private/ directories easier.
Comment | File | Size | Author |
---|---|---|---|
provision-provision_drupal_sync_site_back.patch | 1.81 KB | helmo |
Comments
Comment #1
anarcat CreditAttribution: anarcat commentedPlease mark issues with patches as needs review. Thanks for the patch, it looks sound.
Comment #2
helmo CreditAttribution: helmo commentedPlease have a look at this...
Comment #3
anarcat CreditAttribution: anarcat commentedI have committed this as is, because it's been blocking other issues for so long. But i'm not sure where this naming scheme is heading... "sync" is neutral, it has no sense of direction. So adding "_back" only adds to the confusion. Should we have _upload() and _download() hooks instead?
Comment #4
helmo CreditAttribution: helmo commentedAlthough sync is neutral we mostly use it to mean push.
We do have fetch() methods, maybe we should use that and 'push'.
Comment #5
anarcat CreditAttribution: anarcat commentedAgreed, do you want to take on the rename? We need to open an issue and do this in 2.x, which means replacing all occurences and updating the upgrade path docs.
Comment #6
helmo CreditAttribution: helmo commentedI've opened #1945950: Rename provision_drupal_sync_site_back() as a followup.
Comment #7
Iztok CreditAttribution: Iztok commentedIs there a way to sync from remote to master in 6.x-1.x version, maybe addon?
Comment #8
helmo CreditAttribution: helmo commented@Iztok: I don't understand your question, but this issue is about a small refactoring of a function, and probably not the best place to ask. Please open a new issue, of checkout the community site
Comment #9
helmo CreditAttribution: helmo commented@anarcat: I can't find this in git. Could it be that it was never pushed?
Comment #10
anarcat CreditAttribution: anarcat commentedIt sure looks like I forgot to push it - sorry! Just did.