Allow area handlers to override the page title when used in an empty area. [#1808542]

Currently there is a custom area handler used for the empty text in #1806334: Replace the node listing at /node with a view. This should be an option on area handlers to override the title, if the view is empty.

I have code for this but it would be better to wait for #1807624: Saving and rendering in empty region for 'Global: unfiltered' text does not work to be committed, as it fixes the empty area handling. I will then re roll what I have for this.

Comment	File	Size	Author
#9	1808542-9.patch	3.21 KB	damiankloip
#9
#6	1808542-6.patch	3.21 KB	damiankloip
#6
#4	1808542-4.patch	1.88 KB	damiankloip
#4

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

damiankloip CreditAttribution: damiankloip commented 10 October 2012 at 12:20

Title:

Allow area handlers to override the page title when used in empty area.

» Allow area handlers to override the page title when used in an empty area.

Comment #2

dawehner

German

CreditAttribution: dawehner commented 10 October 2012 at 12:32

For me it seems to make more sense to have an extra area handler which can override the title and one which can just display some custom text.

Comment #3

damiankloip CreditAttribution: damiankloip commented 10 October 2012 at 12:43

Good idea. I'll modify it for that!

Comment #4

damiankloip CreditAttribution: damiankloip commented 10 October 2012 at 13:11

Status:

Active

» Needs review

File	Size
1808542-4.patch	1.88 KB

Comment #5

dawehner

German

CreditAttribution: dawehner commented 10 October 2012 at 13:16

Status:

Needs review

» Needs work

+++ b/lib/Drupal/views/Plugin/views/area/Title.phpundefined
@@ -0,0 +1,49 @@
+  protected function defineOptions() {

Can haz commentz?

+++ b/lib/Drupal/views/Plugin/views/area/Title.phpundefined
@@ -0,0 +1,49 @@
+    if (!empty($this->options['title'])) {
+      $this->view->setTitle(filter_xss_admin($this->options['title']), PASS_THROUGH);

Does this support tokens? We might refer them in the form as well.

+++ b/lib/Drupal/views/Plugin/views/area/Title.phpundefined
@@ -0,0 +1,49 @@
+    return;

Just a nitpick: An empty string sounds helpful.

Comment #6

damiankloip CreditAttribution: damiankloip commented 10 October 2012 at 14:46

Status:

Needs work

» Needs review

File	Size
1808542-6.patch	3.21 KB

Thanks for the review. Comments added, render() now returns an empty string. I have also added a test for this.

I have created a new issue so we can move the token code into the AreaPluginBase class: #1808648: Move tokenization form code into AreaPluginBase and use that in this plugin.

Comment #7

tim.plunkett

he/him

English

Philadelphia

CreditAttribution: tim.plunkett commented 10 October 2012 at 15:06

+++ b/lib/Drupal/views/Tests/Handler/AreaTest.phpundefined
@@ -104,4 +104,30 @@ class AreaTest extends HandlerTestBase {
+    $view->initDisplay('page');

I thought we were switching to 'page_1' everywhere?

+++ b/lib/Drupal/views/Tests/Handler/AreaTest.phpundefined
@@ -104,4 +104,30 @@ class AreaTest extends HandlerTestBase {
+          'id' => 'title',
+          'table' => 'views',
+          'field' => 'title',
+          'admin_label' => '',
+          'label' => '',
+          'empty' => '0',
+          'title' => 'Overridden title',

This is indented too far.