Add views_create_view wrapper function and update view creation code in instantiate_plugin method of WizardPluginBase [#1804178]

Currently we are doing this to create a new view:

    $view = views_new_view();
    $view->name = $form_state['values']['name'];
    $view->human_name = $form_state['values']['human_name'];
    $view->description = $form_state['values']['description'];
    $view->tag = 'default';
    $view->core = VERSION;
    $view->base_table = $this->base_table;

We should pass these parameters (only ones that are needed) into a create method instead. I have also created a views_create_view wrapper function for entity_create as we currently have for views_new_view.

The patch also contains a couple of small doc amends.

Comment	File	Size	Author
	views-wizard-create-view-cleanup.patch	2.33 KB	damiankloip

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

dawehner

German

CreditAttribution: dawehner commented 5 October 2012 at 08:56

+++ b/lib/Drupal/views/Plugin/views/wizard/WizardPluginBase.phpundefined
@@ -543,18 +543,19 @@ abstract class WizardPluginBase extends PluginBase implements WizardInterface {
-    $view->tag = 'default';

I totally agree that using 'default' for a tag doesn't make sense, but why remote 'core' out of that?