Use the alter decorator [#1802852]

Comment	File	Size	Author
#4	1802852-4.patch	6.86 KB	damiankloip

#3	views-1802852-3.patch	5.82 KB	dawehner

#2	views-1802852-2.patch	6.26 KB	dawehner

#1	views-1802852-1.patch	3.23 KB	dawehner

Comment #1

German

CreditAttribution: dawehner commented 4 October 2012 at 06:00

File	Size
views-1802852-1.patch	3.23 KB

It is in general not know how you decide which plugin types should get which kind of decorators.

Let's add the AlterDecorator to all of them.

Log in or register to post comments

Comment #2

dawehner

German

CreditAttribution: dawehner commented 4 October 2012 at 08:08

File	Size
views-1802852-2.patch	6.26 KB

LOL regarding the different bug fixes required for this patch.

Log in or register to post comments

Comment #3

dawehner

German

CreditAttribution: dawehner commented 4 October 2012 at 08:24

File	Size
views-1802852-3.patch	5.82 KB

+++ b/views.moduleundefined
@@ -930,6 +930,7 @@ function views_add_contextual_links(&$render_element, $location, ViewExecutable
+    dsm($plugin);

Let's brake the bot!

+++ b/views.moduleundefined
@@ -954,14 +955,14 @@ function views_add_contextual_links(&$render_element, $location, ViewExecutable
+            // (for example, "path/to/{$view->storage->property}", where $view->property

This should use $view->property as well.

Log in or register to post comments

Comment #4

damiankloip CreditAttribution: damiankloip commented 4 October 2012 at 15:34

Status:

Needs review

» Needs work

File	Size
1802852-4.patch	6.86 KB

+++ b/lib/Drupal/views/Plugin/Type/JoinManager.phpundefined
@@ -28,7 +29,7 @@ class JoinManager extends PluginManagerBase {
+    $this->discovery = new CacheDecorator(new AlterDecorator(new AnnotatedClassDiscovery('views', 'join'), 'views_plugins_join'), 'views:join', 'views_info');

Should we consider breaking this apart, so it's not a one liner. It's getting trickier to read :)

I have added some quick tests to dawehner's patch above in this patch.