This is a sub-task of #500866: [META] remove t() from assert message focused on the new Action module.

In D8 per http://drupal.org/simpletest-tutorial-drupal7#t, best practice is to remove t() from assert messages in tests. When necessary, t() should be replaced with format_string().

There are approximately 10 changes needed in two Test files. This issue includes conversion of all format_patch() occurances as well.

CommentFileSizeAuthor
#1 1798954-1-t-action.patch5.03 KBLars Toomre
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Lars Toomre’s picture

Lars Toomre CreditAttribution: Lars Toomre commented
FileSize
1798954-1-t-action.patch5.03 KB

Here is an initial untested patch. It includes a format_string() change.

Lars Toomre’s picture

Lars Toomre CreditAttribution: Lars Toomre commented
Status: Active » Needs review

Helps again to change the status!

Lars Toomre’s picture

Lars Toomre CreditAttribution: Lars Toomre commented
Issue tags: +Needs backport to D7

When this gets backported to D7, remember that these were broken out from an include file in the system module.

We also need a tag in the component list of this form for 'action.module'. I am unsure how that gets added.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Status: Needs review » Reviewed & tested by the community

Exactly all cleaned

Lars Toomre’s picture

Lars Toomre CreditAttribution: Lars Toomre commented

Thanks @andypost!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Assigned: Unassigned » jhodgdon
jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Title: Remove t() from test asserts in Action module » Remove t() from test asserts in Action module [part of system tests in d7]
Component: base system » action.module
Assigned: jhodgdon » Unassigned
Status: Reviewed & tested by the community » Fixed
Issue tags: -Needs backport to D7

Committed to 8.x. As this is part of system.module tests for D7, I am not marking for backport.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) CreditAttribution: commented
Issue summary: View changes

Added counts from initial patch.