Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
change all instances of variable_set/get/delete menu_masks to the state system.
Comment | File | Size | Author |
---|---|---|---|
#13 | 1798760-menumasks-drupal8-13.patch | 2.71 KB | alexpott |
#12 | 1798760-menumasks-drupal8-12.patch | 2.72 KB | ACF |
#11 | 1798760-menumasks-drupal8-11.patch | 2.51 KB | ACF |
#9 | 1798760-menumasks-drupal8-9.patch | 2.42 KB | ACF |
#1 | 1798760-menumasks-drupal8-1.patch | 1.92 KB | ACF |
Comments
Comment #1
ACF CreditAttribution: ACF commentedMenu masks updated.
Comment #2
ACF CreditAttribution: ACF commentedComment #3
alexpottLooks good. No upgrade path needed since the menu router will be rebuilt during d7 to d8 upgrade.
Tested - thanks for the work.
Comment #4
chx CreditAttribution: chx commentedThis one is good, yes, thanks.
Comment #5
alexpottActually just realised that we should be cleaning up the variables table on upgrade! :)
So in this case we need a menu_update_N function to do a
update_variable_del('menu_masks')
Comment #6
Lars Toomre CreditAttribution: Lars Toomre commentedMaybe it can go into the same menu_update_N function that also includes update_variable_del('menu_rebuild_needed')?
Comment #7
alexpott@Lars there will probably a clean up of the update functions but doing that now would be premature - adding a new function is the way to go at the moment.
Comment #8
Lars Toomre CreditAttribution: Lars Toomre commentedFair enough @alexpott! I was just working on cron_last conversion which I know will need a system_update_N function like many other state variables. I was just trying to be helpful from what I had already seen.
Comment #9
ACF CreditAttribution: ACF commentedUpdated with variable delete added.
Comment #10
Lars Toomre CreditAttribution: Lars Toomre commented#9 looks good.
The only thing I would add is an inline comment that summarizes the thought in #3. That will help others who might wonder why there is no upgrade path for whatever was stored in that variable in D7.
Comment #11
ACF CreditAttribution: ACF commentedAdded comment, thanks.
Comment #12
ACF CreditAttribution: ACF commentedJust seen the change naming convention for the variable and have changed the patch.
Comment #13
alexpottLooks good... just bumped the update to system_update_8028
Comment #14
webchickGreat work, thanks!
Committed and pushed to 8.x.
Comment #15
webchickBtw, that comment didn't wrap at 80 chars so I changed it to: