Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Part of meta #500866: [META] remove t() from assert message.
Comment | File | Size | Author |
---|---|---|---|
#10 | field-ui-1797170-10.patch | 20.09 KB | dcam |
#7 | field-ui-1797170-7.patch | 20.11 KB | dcam |
#1 | field_ui-1797170-1.patch | 21.44 KB | xjm |
Comments
Comment #1
xjmIncludes both "simple" assertions and ones that require
format_string()
, because there weren't very many.You can apply locally and use
git diff --color-words
to review.Comment #2
xjmComment #3
Lars Toomre CreditAttribution: Lars Toomre commentedI have reviewed each one of the message changes in this patch and all are appropriate. I did note one instance of a double quoted string that could be turned to single quoted, but that hardly is reason to re-roll this patch. Hence, with green back from the test bot, this is RTBC!
Comment #4
xjmThanks Lars!
Tagging for backport for consistency.
Comment #5
xjmComment #6
jhodgdonPhew! I think that's the last of them for the moment. Thanks all!
Comment #7
dcam CreditAttribution: dcam commentedBackported #1 to D7.
Comment #8
dcam CreditAttribution: dcam commented#7: field-ui-1797170-7.patch queued for re-testing.
Comment #10
dcam CreditAttribution: dcam commentedRerolled #7.
Comment #11
dcam CreditAttribution: dcam commentedTagging as Novice.
Comment #12
izus CreditAttribution: izus commented#10: field-ui-1797170-10.patch queued for re-testing.
Comment #13
izus CreditAttribution: izus commentedhi,
the patch seems ok
Thanks
Comment #14
dcam CreditAttribution: dcam commentedThanks for the review, izus!
Comment #15
jhodgdonThanks all! Committed to 7.x and this one is taken care of.