Left out the deleting because we maybe need them for the upgrade path.

CommentFileSizeAuthor
#5 views-1794918-5.patch4.27 KBdawehner
#3 views-1794918-3.patch4.26 KBdawehner
#1 views-1794918-1.patch3.94 KBdawehner
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Active » Needs review
FileSize
views-1794918-1.patch3.94 KB

.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented

Funny, I was just wondering about killing that today as I grepped for 'position' :)
Should we drop the tables in a hook_update_N?

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
FileSize
views-1794918-3.patch4.26 KB

He i had the same question, see initial comment :)
I guess there is no way to do the upgrade path just in d8, but we have to write something in d7
so let's drop the table.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Needs review » Needs work 
+++ b/views.installundefined
@@ -206,3 +107,12 @@ function views_update_8001() {
+ * Remove the {views} and {views_display} table.
+ */
+function views_update_8002() {
+  db_drop_table('views');

Shouldn't that be views_view? In both the comment and the drop.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs work » Needs review
FileSize
views-1794918-5.patch4.27 KB

You are absolutely right, this happens if you replace database with awesome sauce of config.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Needs review » Reviewed & tested by the community
tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Reviewed & tested by the community » Fixed

http://drupalcode.org/project/views.git/commit/479698d
Committed

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

Thank you! Committed and pushed

Automatically closed -- issue fixed for 2 weeks with no activity.