Clean up and fix views.drush.inc

+++ b/drush/views.drush.incundefined
@@ -263,235 +123,259 @@ function drush_views_list() {
+    $status_bool = ($status == 'enabled') ? TRUE : FALSE;

isn't it enough to just use $status == 'enabled' ?

+++ b/drush/views.drush.incundefined
@@ -263,235 +123,259 @@ function drush_views_list() {
-      $summary .= " tagged $tags";
...
+      $summary .= ' ' . dt('tagged with "@tags"', array('@tags' => $tags));

I like this change!

+++ b/drush/views.drush.incundefined
@@ -263,235 +123,259 @@ function drush_views_list() {
+  $views = entity_get_controller('view')->load($viewnames);

Just a small simplification couldn't be just use entity_load_multiple and if ($views = entity_load_multiple...) ?

+++ b/drush/views.drush.incundefined
@@ -263,235 +123,256 @@ function drush_views_list() {
+  $viewnames = func_get_args();

Should be $view_names

+++ b/drush/views.drush.incundefined
@@ -263,235 +123,256 @@ function drush_views_list() {
+function _views_drush_op($op = '', array $viewnames = array()) {

$view_names again

----

Running drush va gives me the wonderful

WD php: Symfony\Component\DependencyInjection\Exception\InvalidArgumentException: The service definition "plugin.manager.views.display" does not exist. in             [error]
Symfony\Component\DependencyInjection\ContainerBuilder->getDefinition() (line 690 of
/Users/tim/www/d8/core/vendor/symfony/dependency-injection/Symfony/Component/DependencyInjection/ContainerBuilder.php).
Symfony\Component\DependencyInjection\Exception\InvalidArgumentException: The service definition "plugin.manager.views.display" does not exist. in Symfony\Component\DependencyInjection\ContainerBuilder->getDefinition() (line 690 of /Users/tim/www/d8/core/vendor/symfony/dependency-injection/Symfony/Component/DependencyInjection/ContainerBuilder.php).
Drush command terminated abnormally due to an unrecoverable error.   

Not really much we can do about that though....

Even the update.php can't be runned at the moment, but hey this cleanup is worth to get it.

Well, turns out there is a problem with Analyzer. I was trying out the code manually in devel/php, and it turned out that Drush is the only place that views_include('analyze');, so it was the only time that the bug in anaylzer was caught.

It's a hook, so it should be in the .module. Because of the move, the bug fix is not apparent; it was just s/$view->display/$view-displayHandlers

Whoops, rolled that while on the wrong branch.

I'm fine with this, but I think someone else should look/commit it.

I'm totally fine with the analyze code. I just remember that the node: status analyze worked fine back in time.

Committed and pushed