Cleanup naming of resultskey, outputkey

+++ b/lib/Drupal/views/Plugin/views/cache/CachePluginBase.phpundefined
@@ -38,22 +38,22 @@ abstract class CachePluginBase extends PluginBase {
+   * Stores the cache id used for the results cache, once generateResultsKey() got
    * executed.
...
+   * Stores the cache id used for the output cache, once generateOutputKey() got
    * executed.

This is now over 80, but should be one line. Also, ID, not id.

+++ b/lib/Drupal/views/Plugin/views/cache/CachePluginBase.phpundefined
@@ -272,15 +290,13 @@ abstract class CachePluginBase extends PluginBase {
-  function get_results_key() {
+  public function generateResultsKey() {

@@ -303,15 +319,15 @@ abstract class CachePluginBase extends PluginBase {
-  function get_output_key() {
+  function generateOutputKey() {
     global $user;

Might as well add a docblock while we're changing it

+++ b/lib/Drupal/views/Plugin/views/cache/CachePluginBase.phpundefined
@@ -38,22 +39,22 @@ abstract class CachePluginBase extends PluginBase {
+   * @see Drupal\views\Plugin\views\cache\CachePluginBase::generateResultsKey()
    * @var string
    */

There is a rule we should move @see to the end. I must admit I never saw it when dealing with a property.

+++ b/lib/Drupal/views/Plugin/views/cache/CachePluginBase.phpundefined
@@ -72,6 +73,24 @@ abstract class CachePluginBase extends PluginBase {
+   * @return string
+   */

I know its obvious but we need to add a line of documentation. Same for the other functions.

+++ b/lib/Drupal/views/Plugin/views/cache/CachePluginBase.phpundefined
@@ -99,7 +118,7 @@ abstract class CachePluginBase extends PluginBase {
   function cache_set_expire($type) {
-    return CACHE_PERMANENT;
+    return CacheBackendInterface::CACHE_PERMANENT;

Why do we need to pass the $type?

Small detail

+++ b/lib/Drupal/views/Plugin/views/cache/CachePluginBase.phpundefined
@@ -38,22 +39,24 @@ abstract class CachePluginBase extends PluginBase {
+   * Stores the cache ID used for the results cache, once generateResultsKey()
+   * got executed.
    *

Srry but this should fit on one line. We can make a more detailed description on a new line.

go?