Split ViewTest between ViewStorageTest and ViewExecutableTest

Also, in ViewStorageTest, there are a couple places checking $view->executable directly. Those should probably be moved too.

I cleaned up some stuff.
I think its weird to call getExecutable() in the storage test, but that just makes it clear that newDisplay/addDisplay are weird methods.

RTBCing in the hope that it passes.

Hmm, missed something I guess. In the meantime.

+++ b/lib/Drupal/views/Tests/ViewExecutableTest.phpundefined
@@ -103,4 +122,81 @@ public function testDisplays() {
+    $this->assertFalse(isset($view->filter), 'Make sure all handlers are destroyed');
+    $this->assertFalse(isset($view->field), 'Make sure all handlers are destroyed');
+    $this->assertFalse(isset($view->argument), 'Make sure all handlers are destroyed');
+    $this->assertFalse(isset($view->relationship), 'Make sure all handlers are destroyed');
+    $this->assertFalse(isset($view->sort), 'Make sure all handlers are destroyed');
+    $this->assertFalse(isset($view->area), 'Make sure all handlers are destroyed');

Might as well say which type of handler in the message.

+++ b/lib/Drupal/views/Tests/ViewExecutableTest.phpundefined
@@ -103,4 +122,81 @@ public function testDisplays() {
+      // @todo The key on the display should be footers, headers and empties
+      // or something similar instead of the singular, but so long check for
+      // this special case.

The following two lines should be indented

+++ b/lib/Drupal/views/Tests/ViewExecutableTest.phpundefined
@@ -103,4 +122,81 @@ public function testDisplays() {
+    // @todo: Create an extra validation view.

No : needed

+++ b/lib/Drupal/views/Tests/ViewExecutableTest.phpundefined
@@ -103,4 +122,81 @@ public function testDisplays() {
+    // @todo: Write real tests for the validation.
+    // In general the following things could be tested:
+    // - Deleted displays shouldn't be validated
+    // - Multiple displays are validating and the errors are merged together.

No :, and indent the following lines

+++ b/lib/Drupal/views/Tests/ViewStorageTest.phpundefined
@@ -429,4 +431,43 @@ protected function displayMethodTests() {
+    // Check that the original view and the copy have different uuids.

UUIDs

+++ b/lib/Drupal/views/Tests/ViewStorageTest.phpundefined
@@ -429,4 +431,43 @@ protected function displayMethodTests() {
+    // Check the 'name' (id) is using the View objects default value ('') as it

ID

http://drupalcode.org/project/views.git/commit/3895a6f
Removed the two debug() calls and committed.