Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.I did this as part of #1788266: Access the different views related properties on the right object, but it wasn't complete and should be its own issue.
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | views-1792454-11.patch | 44.86 KB | tim.plunkett |
| #1 | views-1792454-1.patch | 44.83 KB | tim.plunkett |
Comments
Comment #1
tim.plunkettHere's what I had so far.
Comment #4
dawehnerMarked #1199328: Add typehints and remove obsolete reference indicators for objects as duplicate.
Comment #5
Lars Toomre CreditAttribution: Lars Toomre commentedLooking at the patch in #1, I see several &$view pass by reference were changed to pass by value. Was that intentional?
I also noticed that a number of docblocks are missing and/or incomplete. I believe that the type hints should be added to the appropriate @param directives as well.
Comment #6
tim.plunkettThis is PHP 5, objects don't need to be passed by reference.
The docblocks are missing in the original code, that's a separate issue and unrelated to this patch, which will be big enough on its own.
Comment #7
Lars Toomre CreditAttribution: Lars Toomre commentedThanks @tim. Is there an issue for the missing docblocks? I did not see one when I looked. Would you like me to open such as issue?
Comment #8
tim.plunkettOpening and issue and submitting a patch would be great.
Comment #9
Lars Toomre CreditAttribution: Lars Toomre commented@tim What sandbox and which branch should I use to roll a path for missing docblocks from? I need to the edits locally and then upload a patch. Thanks in advance.
Comment #10
dawehnerIt is all happening in the 8.x-3.x branch of views itself
Comment #11
tim.plunkettGetting back to the actual issue...
Comment #12
dawehnerCommitted with the knowledge to have to do another rerole. I hate wasting time :(