We should call the parent method in attachLoad() as it invokes the hook_entity_load hooks etc..

CommentFileSizeAuthor
#3 1791242-3.patch1.46 KBdamiankloip
views-attachLoad-parent.patch438 bytesdamiankloip
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Reviewed & tested by the community

I totally agree!

Status: Reviewed & tested by the community » Needs work

The last submitted patch, views-attachLoad-parent.patch, failed testing.

damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented
Status: Needs work » Needs review
FileSize
1791242-3.patch1.46 KB

Good spot from dawehner; views_ui_view_load is being called by hook_$entityType_load

Status: Needs review » Needs work
Issue tags: -VDC

The last submitted patch, 1791242-3.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs work » Needs review
Issue tags: +VDC

#3: 1791242-3.patch queued for re-testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Needs review » Fixed

http://drupalcode.org/project/views.git/commit/c569255

Automatically closed -- issue fixed for 2 weeks with no activity.