#1564832: Remove _node_extract_type() and node_type_get_name() removed the function, and it didn't break any tests.

CommentFileSizeAuthor
#4 views-1790484-4-FAIL.patch1.98 KBtim.plunkett
#4 views-1790484-4-PASS.patch3.05 KBtim.plunkett
#1 views-1790484-1-FAIL.patch2.15 KBtim.plunkett
#1 views-1790484-1-PASS.patch3.23 KBtim.plunkett
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Active » Needs review
FileSize
views-1790484-1-PASS.patch3.23 KB
views-1790484-1-FAIL.patch2.15 KB

See attached.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Priority: Normal » Major

This is causing a fatal in the CTools tests http://qa.drupal.org/pifr/test/274403

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented

#1: views-1790484-1-FAIL.patch queued for re-testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
FileSize
views-1790484-4-PASS.patch3.05 KB
views-1790484-4-FAIL.patch1.98 KB

D'oh.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs review » Reviewed & tested by the community

Looks good

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Reviewed & tested by the community » Fixed

Thanks!
http://drupalcode.org/project/views.git/commit/aa6f63e

Automatically closed -- issue fixed for 2 weeks with no activity.