Remove references to 'active store' in comments for configuration system [#1788462]

There are several references to the 'active store' in comments surrounding the configuration system right now. These need to be removed and replaced, I am going to suggest 'active configuration' as a replacement. The one exception is in DatabaseStorageTest.php where I would replace the line

'description' => 'Default active store for the configuration system.',

with

'description' => 'Database storage for the configuration system.',

Comment	File	Size	Author
#8	remove-active-store-refs-1788462-8.patch	7.88 KB	samhassell
#8
#6	remove-active-store-refs-1788462-6.patch	7.88 KB	samhassell
#6
#2	remove-active-store-refs-1788462-1.patch	7.63 KB	samhassell
#2

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

samhassell CreditAttribution: samhassell commented 19 September 2012 at 11:41

Assigned:

Unassigned

» samhassell

Comment #2

samhassell CreditAttribution: samhassell commented 19 September 2012 at 11:56

Status:

Active

» Needs review

File	Size
remove-active-store-refs-1788462-1.patch	7.63 KB

Patch attached.

Comment #3

mheinke CreditAttribution: mheinke commented 19 September 2012 at 16:25

Issue tags:

-Configuration system, -Config novice

#2: remove-active-store-refs-1788462-1.patch queued for re-testing.

Comment #4

michaellenahan CreditAttribution: michaellenahan commented 19 September 2012 at 20:06

Issue tags:

+Configuration system, +Config novice

#2: remove-active-store-refs-1788462-1.patch queued for re-testing.

Comment #5

gdd

he/him

English

Portland, OR

CreditAttribution: gdd commented 20 September 2012 at 21:21

Status:

Needs review

» Needs work

+++ b/core/includes/config.incundefined
@@ -213,10 +213,10 @@ function config_import_invoke_owner(array $config_changes, StorageInterface $sou
+ * Exports configuration from the active configuration to staging.

This reads really awkwardly to me, but I'm not sure about what would be better.

+++ b/core/lib/Drupal/Core/Config/NullStorage.phpundefined
@@ -15,7 +15,7 @@ namespace Drupal\Core\Config;
- * able to short-circuit the full diff against the active store; the diff would

Nitpick but this is over 80 columns.

+++ b/core/modules/system/lib/Drupal/system/Tests/Module/ModuleTestBase.phpundefined
@@ -104,7 +104,7 @@ abstract class ModuleTestBase extends WebTestBase {
-    // Look up each default configuration object name in the active store, and

this one too

Comment #6

samhassell CreditAttribution: samhassell commented 21 September 2012 at 10:53

Status:

Needs work

» Needs review

File	Size
remove-active-store-refs-1788462-6.patch	7.88 KB

Rerolled with the changes.

"Exports configuration from the active configuration to staging."

How about "Exports the active configuration to staging."?

Gets rid of the redundant 'configuration'.

Comment #7

kbasarab CreditAttribution: kbasarab commented 5 October 2012 at 17:16

Status:

Needs review

» Needs work

+++ b/core/lib/Drupal/Core/Config/NullStorage.phpundefined
@@ -15,9 +15,9 @@ namespace Drupal\Core\Config;
+ * able to short-circuit the full diff against the active configuration; the ¶
+ * diff would yield all currently available configuration as items to remove, ¶

Trailing whitespace on these two lines.

+++ b/core/modules/system/lib/Drupal/system/Tests/Module/ModuleTestBase.phpundefined
@@ -104,8 +104,8 @@ abstract class ModuleTestBase extends WebTestBase {
+    // Look up each default configuration object name in the active ¶

Trailing white space again.

I like "Exports the active configuration to staging."