Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner’s picture

Assigned: dawehner » Unassigned
Priority: Normal » Minor
FileSize
21.9 KB

This is definitive some work which is not finished.

tim.plunkett’s picture

Assigned: Unassigned » tim.plunkett
Status: Active » Needs review

More work

Status: Needs review » Needs work

The last submitted patch, propertiers-2.patch, failed testing.

tim.plunkett’s picture

FileSize
49.22 KB

Duh.

tim.plunkett’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, views-1788266-2.patch, failed testing.

tim.plunkett’s picture

Status: Needs work » Needs review
FileSize
49.21 KB

OMG this issue is killing me.

Status: Needs review » Needs work

The last submitted patch, views-1788266-7.patch, failed testing.

tim.plunkett’s picture

Status: Needs work » Needs review
FileSize
48.83 KB

Left in some dpm's

Status: Needs review » Needs work

The last submitted patch, views-1788266-9.patch, failed testing.

tim.plunkett’s picture

Status: Needs work » Needs review
FileSize
68.26 KB

More fixes.

Status: Needs review » Needs work

The last submitted patch, views-1788266-11.patch, failed testing.

tim.plunkett’s picture

Status: Needs work » Needs review
FileSize
77.28 KB

More stuff.

Status: Needs review » Needs work

The last submitted patch, views-1788266-13.patch, failed testing.

tim.plunkett’s picture

Status: Needs work » Needs review
FileSize
85.13 KB

MOAR

Status: Needs review » Needs work

The last submitted patch, views-1788266-15.patch, failed testing.

tim.plunkett’s picture

Status: Needs work » Needs review
FileSize
82.79 KB

One of the tests was asserting that you could get to the properties no matter which object :D

Status: Needs review » Needs work

The last submitted patch, views-1788266-17.patch, failed testing.

tim.plunkett’s picture

Status: Needs work » Needs review
FileSize
92.31 KB

Status: Needs review » Needs work

The last submitted patch, views-1788266-19.patch, failed testing.

tim.plunkett’s picture

Status: Needs work » Needs review
FileSize
93.2 KB

All of the other tests pass locally for me, in the Simpletest UI and from run-tests.sh

Status: Needs review » Needs work

The last submitted patch, views-1788266-21.patch, failed testing.

dawehner’s picture

+++ b/includes/admin.incundefined
@@ -5202,7 +5203,7 @@ function theme_views_ui_style_plugin_table($variables) {
-  $title = $display_id == 'default' ? t('Master') : $view->display[$display_id]['display_title'];
+  $title = $display_id == 'default' ? t('Master') : $view->displayHandlers[$display_id]->display['display_title'];

Sure for this case we can assume that the display handlers are enabled, but i think if possible we should get the information from the display array.

+++ b/views.moduleundefined
@@ -1543,6 +1543,7 @@ function views_get_applicable_views($type) {
+    $view->initDisplay();

@@ -1555,8 +1556,8 @@ function views_get_applicable_views($type) {
+    foreach (array_keys($view->displayHandlers) as $id) {
+      $plugin = views_get_plugin_definition('display', $view->displayHandlers[$id]->display['display_plugin']);

Are we sure we want to do that? views_get_applicable_views is runned on cache clear and load all views, so it should be probably fast if possible, so what about using $view->storage->display ?

tim.plunkett’s picture

Status: Needs work » Needs review
FileSize
99.62 KB

I'm going to test out #23 in a minute, just want to see if this does anything for those fails.

Status: Needs review » Needs work

The last submitted patch, views-1788266-24.patch, failed testing.

tim.plunkett’s picture

Status: Needs work » Needs review
FileSize
137.42 KB

Okay, I decided to type hint more strongly to help catch these last couple errors.

Status: Needs review » Needs work

The last submitted patch, views-1788266-26.patch, failed testing.

tim.plunkett’s picture

Status: Needs work » Needs review
FileSize
158.26 KB

What a rat's nest of bugs!

Status: Needs review » Needs work

The last submitted patch, views-1788266-28.patch, failed testing.

tim.plunkett’s picture

Status: Needs work » Needs review
FileSize
158.27 KB

Whoops!

Status: Needs review » Needs work

The last submitted patch, views-1788266-30.patch, failed testing.

tim.plunkett’s picture

Status: Needs work » Needs review
FileSize
160.02 KB

Okay! I think this is it!

tim.plunkett’s picture

Assigned: tim.plunkett » Unassigned
FileSize
115.48 KB

I opened #1792454: Add type hinting to function signatures for $view for the type hinting parts of this. They helped me debug, but they didn't actually affect the issue.

tim.plunkett’s picture

Assigned: Unassigned » dawehner
Priority: Minor » Normal

This would be a pain to reroll, so assigning for a review/commit.

tim.plunkett’s picture

FileSize
134.37 KB

Also removed __call().

tim.plunkett’s picture

FileSize
145.15 KB

LAST PATCH!
If for some reason this doesn't patch, go with #35 and this can be a follow-up, but it should pass.

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

Scanned the code pretty fast.

dawehner’s picture

Status: Reviewed & tested by the community » Fixed

So committed and pushed.

Automatically closed -- issue fixed for 2 weeks with no activity.