Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.We need to change the string from <Hidden> to - Hidden - like we have done everywhere else. These type of "html"-string is detected as an not allowed HTML tag and the translated string fails to import.
| Comment | File | Size | Author |
|---|---|---|---|
| #19 | 1788060-19-hidden-translation.patch | 928 bytes | dcam |
Comments
Comment #1
BarisW CreditAttribution: BarisW commentedI've changed the format from
<Hidden>to- Hidden -. However, why the Label field should have<>or- -around the label is unclear to me. The three options (Above, Inline or Hidden) are quite OK like this right?Patch and screenshots attached.
Comment #2
hass CreditAttribution: hass commentedComment #3
hass CreditAttribution: hass commentedI think the - or
<>is there to show that this is a very special setting and not really a format.Comment #4
droplet CreditAttribution: droplet commentedI think it should do some fixes similar to this issue #1317884: Remove all instances of <none>, <Hidden> and <br/> from translatable strings because they lead to import errors
Comment #5
BarisW CreditAttribution: BarisW commentedAh, yes. That would be better I guess. Patch attached.
While working in the file, I applied some Drupal coding standards as well.
Comment #6
c960657 CreditAttribution: c960657 commentedFYI:
A similar change was done elsewhere in #1317884: Remove all instances of <none>, <Hidden> and <br/> from translatable strings because they lead to import errors.
The issue about not being able to import strings containing certain special characters (even if you want to) is being discussed in #514926: translated strings shouldn't be validated.
Comment #7
swentel CreditAttribution: swentel commentedCoding standards are attacked in #1533234: Make field_ui module pass Coder Review - so let's focus on the hidden part.
Comment #8
BarisW CreditAttribution: BarisW commentedAllright. Patch attached.
Comment #9
droplet CreditAttribution: droplet commentedCan we mark either one duplicated. I reopen #1317884: Remove all instances of <none>, <Hidden> and <br/> from translatable strings because they lead to import errors as it doesn't really get committed.
and #8 patch may bring out a security problem :
http://drupal.org/node/514926#comment-6497228
Comment #10
swentel CreditAttribution: swentel commentedThe security is not an issue at all, but I'm ok with duplicating, your choice.
Comment #11
BarisW CreditAttribution: BarisW commenteddroplet: that other issue was already closed and committed. They just forgot two strings. Can we not just commit this one and leave the other one closed?
Comment #12
swentel CreditAttribution: swentel commentedYeah re-read that issue, no point in reopening, let's keep this one.
Comment #13
swentel CreditAttribution: swentel commentedThis needs a re-roll now #1792600: Refactor field_ui so common behavior for fields and display overview screens are extracted got in.
Comment #14
swentel CreditAttribution: swentel commentedRerolled because of the move to classes - can go RTBC when it comes back green.
Comment #15
BarisW CreditAttribution: BarisW commentedThe last line contains a double semicolon.
Comment #16
swentel CreditAttribution: swentel commentedOh man .. :)
Comment #17
hass CreditAttribution: hass commentedComment #18
catchCommitted/pushed to 8.x, thanks!
Comment #19
dcam CreditAttribution: dcam commentedBackported #16 to D7.
Comment #20
hass CreditAttribution: hass commented19: 1788060-19-hidden-translation.patch queued for re-testing.
Comment #21
hass CreditAttribution: hass commentedComment #22
hass CreditAttribution: hass commentedComment #23
David_Rothstein CreditAttribution: David_Rothstein commentedCommitted to 7.x - thanks!
(And luckily "Hidden" is already a translatable string in Drupal core before this patch, so we're not actually adding new translatable strings at all here.)