Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Formatters:
- taxonomy_term_reference_link
- taxonomy_term_reference_plain
- taxonomy_term_reference_rss_category
Comment | File | Size | Author |
---|---|---|---|
#30 | taxonomy-formatters-plugins-1787248-30.patch | 12.42 KB | pcambra |
#28 | taxonomy-formatters-plugins-1787248-28.patch | 12.4 KB | pcambra |
#24 | taxonomy-formatters-plugins-1787248-24.patch | 12.55 KB | nils.destoop |
#16 | taxonomy-formatters-plugins-1787248-16.patch | 12.84 KB | jibran |
#12 | taxonomy-formatters-plugins-1787248.patch | 12.84 KB | Sweetchuck |
Comments
Comment #1
Stalski CreditAttribution: Stalski commentedI start working on this, as of NOW
Comment #2
Stalski CreditAttribution: Stalski commentedforgot status change
Comment #3
Stalski CreditAttribution: Stalski commentedComment #4
Stalski CreditAttribution: Stalski commentedRemoved trailing spaces, sorry
Comment #6
pcambraTriggering testbot again
Comment #7
pcambra#4: 1787248_4.patch queued for re-testing.
Comment #8
Stalski CreditAttribution: Stalski commentedFound a comment that was not correct.
Comment #9
webflo CreditAttribution: webflo commentedLooks good. I found one minor issue.
Lets use entity uri
$item['taxonomy_term']->uri()
for consistency.Comment #10
webflo CreditAttribution: webflo commentedRemoved the taxonomy_field_formatter_* hooks and switched to $item['taxonomy_term']->uri() in RSSCategoryFormatter.
Comment #11
Stalski CreditAttribution: Stalski commentedgreat webflo, thx a lot!
Comment #12
SweetchuckNothing new, just it works.
The patch #10 is not applicable to the latest 8.x.
Comment #14
yched CreditAttribution: yched commentedBumping, this is now a blocker for #1950632: Create a FieldDefinitionInterface and use it for formatters and widgets.
Anyone up for reviving this ?
Comment #15
swentel CreditAttribution: swentel commentedCrap, completely forgot about this one
Comment #16
jibranHere is the re-roll lets see how much it fails.
Comment #17
swentel CreditAttribution: swentel commentedI even think it might be green - or at least really close. 2 remarks regarding documentation we need to fix
Should be Contains \Drupal (apparently with leading forward slash now right ?)
Should all be {@inheritdoc}
Comment #18
swentel CreditAttribution: swentel commentedoh and thank you also for the re-roll! :)
Comment #20
ParisLiakos CreditAttribution: ParisLiakos commentedi think thats why this was forgotten
#1847596: Remove Taxonomy term reference field in favor of Entity reference which is postponed on #1818560: Convert taxonomy entities to the new Entity Field API
maybe we should postpone or duplicate it
Comment #21
swentel CreditAttribution: swentel commentedAs far as I can see, #1818560: Convert taxonomy entities to the new Entity Field API wouldn't conflict that much (maybe not at all), so I'd rather go ahead with this one because I think the other one is going to be a while for that goes in I'm afraid.
Comment #22
yched CreditAttribution: yched commentedAgreed with @swentel. Most of the job is done already, and getting to a point where there are no legacy widgets and formatters will be precious to unblock other work.
Comment #23
ParisLiakos CreditAttribution: ParisLiakos commentedagreed..
tagging
Comment #24
nils.destoop CreditAttribution: nils.destoop commentedChanged the documentation, and tests should be fixed.
Comment #25
nils.destoop CreditAttribution: nils.destoop commentedComment #26
effulgentsia CreditAttribution: effulgentsia commented#24 looks great. Just some nits:
The code below this uses $item['entity'] instead of $item['taxonomy_term'], so let's update the comment accordingly. Also, I think the line breaks can be adjusted so that this fits on two lines.
Ditto
And once more.
Is there a reason for an empty implementation of this on the base class? If not, let's remove it and make the class abstract.
Comment #27
effulgentsia CreditAttribution: effulgentsia commentedComment #28
pcambraHere's a reroll with @effulgentsia comments applied, I don't see a reason to the empty implementation either so I've removed it.
Comment #29
swentel CreditAttribution: swentel commentedTwo nitpicks, after that it's good.
80 chars limit
same here
Comment #30
pcambraHere you go :)
Comment #32
effulgentsia CreditAttribution: effulgentsia commented#30: taxonomy-formatters-plugins-1787248-30.patch queued for re-testing.
Comment #33
effulgentsia CreditAttribution: effulgentsia commented#26 and #29 addressed, so RTBC. Thanks!
Comment #34
webchickCommitted and pushed to 8.x. Thanks!