Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Formatters:
- list_default
- list_key
Comment | File | Size | Author |
---|---|---|---|
#31 | list_formatter_plugin_ids-1787238-31.patch | 2.39 KB | yched |
#28 | 1787238-options-formatters-28.patch | 8.15 KB | yched |
#28 | interdiff.txt | 1.34 KB | yched |
#19 | 1787238-options-formatters-19.patch | 8.28 KB | swentel |
#19 | interdiff.txt | 6.91 KB | swentel |
Comments
Comment #1
aspilicious CreditAttribution: aspilicious commentedLet's try this
Comment #2
aspilicious CreditAttribution: aspilicious commentedhmm lets see what this does
Comment #3
aspilicious CreditAttribution: aspilicious commentedNeeds work (and a test)
Comment #4
aspilicious CreditAttribution: aspilicious commentedWriting tests can be a pain...
Comment #6
aspilicious CreditAttribution: aspilicious commentedAnother try...
Comment #8
aspilicious CreditAttribution: aspilicious commentedI almost forgot to finish this. Shame on me.
Comment #9
aspilicious CreditAttribution: aspilicious commentedOk green! :)
I don't have a lot of time to reroll this if needed so I'm unassigning.
I think this is actually done (or very close to done).
Comment #10
nils.destoop CreditAttribution: nils.destoop commentedLooks ok for me.
2 small remarks:
you left a debug in testNodeDisplay:
The comment
on line 42 in OptionsDefaultFormatter can be removed
After that, RTBC :)
Comment #11
aspilicious CreditAttribution: aspilicious commentedShould be ok now :)
Comment #12
aspilicious CreditAttribution: aspilicious commentedDidn't apply anymore, can we get this in?
Comment #13
aspilicious CreditAttribution: aspilicious commentedWrong upload...
Comment #14
dawehnerContains ...
Should we maybe start to prefix the plugin IDs with the module for formatters as well?
Better not put an ending "," here.
Missing starting "\"
"\"
Does the user really need all this permissions? For example administer users doesn't seem to be required?
Shouldn't be document this new variable?
No t() function for assertion messages needed.
Missing dot at the end.
There should be a new line at the end of the file.
Nitpick: Contains \ ...
Comment #15
aspilicious CreditAttribution: aspilicious commentedAnother try :)
Comment #16
dawehnerYou seemed to have miss a lot of the points I made :)
Comment #17
aspilicious CreditAttribution: aspilicious commentedI'm so tired... Uploaded wrong patch
Comment #19
swentel CreditAttribution: swentel commentedWe need this for #1875992: Add EntityFormDisplay objects for entity forms - so new patch here, hopefully green and a fast RTBC :)
Somehow you missed the extension also in the patch :)
Comment #20
aspilicious CreditAttribution: aspilicious commentedThank you! :D
Comment #21
aspilicious CreditAttribution: aspilicious commentedComment #22
catchShould the doc header really say "Plugin implemention of..." - that seems like a conversion thing, every formatter will be a plugin once conversions are done.
Comment #23
amateescu CreditAttribution: amateescu commentedThis is one of the last two formatter conversion patches (the other one is #1796316: Convert Link/URL widgets / formatters to plugin system) and *all* formatters from HEAD have this short description. Starting to diverge from it here would mean to be inconsistent with them so maybe we can make this change for all formatter and widget plugins in #1955678: Remove formatter and widgets legacy plugin?
Comment #24
xjm#19: 1787238-options-formatters-19.patch queued for re-testing.
Comment #25
swentel CreditAttribution: swentel commentedWe're going to postpone on #1735118: Convert Field API to CMI, that one is close, bear with us folks!
Comment #26
dawehnerNow it's unblocked.
Comment #27
yched CreditAttribution: yched commented#19: 1787238-options-formatters-19.patch queued for re-testing.
Comment #28
yched CreditAttribution: yched commentedStill green.
Attached patch just moves phpdocs to the new {@inheritdoc} standard.
Thus, back to RTBC.
Comment #29
alexpottCommitted e9aa9c4 and pushed to 8.x. Thanks!
Comment #31
yched CreditAttribution: yched commentedThe patch inadvertently changed the formatter plugin ids:
'list_default' became 'options_list_default'
'list_key' became 'options_list_key'
We should get back to the previous names, or fields migrated from D7 will lose their formatters.
(also, the 'default_formatter' property in the field type definitions still refer to the old plugin ids)
Comment #32
dawehnerThis seems to be related with #1980632: Viewing a node with a List field results in fatal error
Comment #33
yched CreditAttribution: yched commentedOK, let's handle this in #1980632: Viewing a node with a List field results in fatal error