This a subtask of issue 421118 for a complete history and links to the other subtasks see #421118: [Meta] Standardize capitalization on actions

Problem/Motivation

Lowercase action words are harder to translate. Many contributed modules, like Organic Groups and Views, already use uppercase action words.
To make this task better manageable we decided to split it on a module basis.

Proposed resolution

Change delete to Delete, configure to Configure, view to View, etc.

Remaining tasks

We need a patch for the "update items" module.

CommentFileSizeAuthor
#11 1784784 - aggregator - after.png96.03 KBbeltofte
#11 1784784 - aggregator - before.png96.35 KBbeltofte
#9 1784784.patch2.17 KBbeltofte
#7 1784784 - after.png65.08 KBbeltofte
#6 1784784.patch1.4 KBbeltofte
#6 1784784 - after.png.png59.22 KBbeltofte
#6 1784784 - before.png101.65 KBbeltofte
#4 1784784-standardize-capitalization-update-items.patch633 bytesbeltofte
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

YesCT’s picture

YesCT CreditAttribution: YesCT commented
Title: [Meta] Standardize capitalization on actions and short sentences [update items] » Standardize capitalization on actions and short sentences [update items]
YesCT’s picture

YesCT CreditAttribution: YesCT commented
Issue summary: View changes

clarification

YesCT’s picture

YesCT CreditAttribution: YesCT commented
Status: Needs work » Active
YesCT’s picture

YesCT CreditAttribution: YesCT commented
Issue tags: +Novice
beltofte’s picture

beltofte
Primary language Danish
Location Copenhagen 🇩🇰
CreditAttribution: beltofte commented
Status: Active » Needs review
FileSize
1784784-standardize-capitalization-update-items.patch633 bytes

Attaching patch.

YesCT’s picture

YesCT CreditAttribution: YesCT commented
Title: Standardize capitalization on actions and short sentences [update items] » Standardize capitalization on actions, in aggregator: 'update items', 'remove items'
Status: Needs review » Needs work
Issue tags: +Needs screenshots

bring #1784768: Standardize capitalization on actions and short sentences [remove items] into here and do the aggregator stuff here.

beltofte’s picture

beltofte
Primary language Danish
Location Copenhagen 🇩🇰
CreditAttribution: beltofte commented
Assigned: Unassigned » beltofte
Status: Needs work » Needs review
FileSize
1784784 - before.png101.65 KB
1784784 - after.png.png59.22 KB
1784784.patch1.4 KB

Updated patch + before and after screenshots. Notice all the operation links are changed, but you can't see them in the screenshot.

beltofte’s picture

beltofte
Primary language Danish
Location Copenhagen 🇩🇰
CreditAttribution: beltofte commented
FileSize
1784784 - after.png65.08 KB

Updated after screenshot with arrows.

Status: Needs review » Needs work

The last submitted patch, 1784784.patch, failed testing.

beltofte’s picture

beltofte
Primary language Danish
Location Copenhagen 🇩🇰
CreditAttribution: beltofte commented
FileSize
1784784.patch2.17 KB

Trying new patch....

beltofte’s picture

beltofte
Primary language Danish
Location Copenhagen 🇩🇰
CreditAttribution: beltofte commented
Status: Needs work » Needs review
beltofte’s picture

beltofte
Primary language Danish
Location Copenhagen 🇩🇰
CreditAttribution: beltofte commented
FileSize
1784784 - aggregator - before.png96.35 KB
1784784 - aggregator - after.png96.03 KB

Adding screenshots of the patch in #9.

Aggregator before:
1784784 - aggregator - before.png

Aggregator after:
1784784 - aggregator - after.png

shnark’s picture

shnark CreditAttribution: shnark commented
Status: Needs review » Reviewed & tested by the community

The screenshots look good. I reviewed the code, the changes made sense, and there was no extra whitespace.

YesCT’s picture

YesCT CreditAttribution: YesCT commented
Issue tags: -Needs screenshots

changes look good to me too.

@EllaTheHarpy for more complicated code changes (maybe in other issues you might come across), there is a massive amount of coding standards things to look at: http://drupal.org/coding-standards
For this issue, I think it's fine.

removing needs screenshot tag, since we have them here for the most recent patch.

hass’s picture

hass CreditAttribution: hass commented

Looks good. RTBC.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) CreditAttribution: commented
Issue summary: View changes

fix copy paste error