We don't need it as it is part of the definition. One property down!

CommentFileSizeAuthor
#6 views-1778960-6.patch1.69 KBtim.plunkett
remove-plugin-type-property.patch1.77 KBaspilicious
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Status: Needs review » Needs work

The last submitted patch, remove-plugin-type-property.patch, failed testing.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented

This failure seems so unrelated....

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs work » Needs review

remove-plugin-type-property.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, remove-plugin-type-property.patch, failed testing.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs work » Needs review

remove-plugin-type-property.patch queued for re-testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
FileSize
views-1778960-6.patch1.69 KB 
+++ b/lib/Drupal/views/Plugin/views/HandlerBase.phpundefined
@@ -105,9 +105,10 @@ abstract class HandlerBase extends PluginBase {
+    $plugin_type = $this->definition['plugin_type'];
+    $plural = $plugin_type;

Why not combine these lines?

Like this.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs review » Reviewed & tested by the community

Whatevaaaah, is ok

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Reviewed & tested by the community » Fixed

http://drupalcode.org/project/views.git/commit/4d03ae5
Woot!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.