Create a node_language argument plugin [#1778768]

#1777194: One handler test to rule them all reveiled something nasty.

  // language
  $data['users']['language']['moved to'] = array('users', 'langcode');
  $data['users']['langcode'] = array(
    'title' => t('Language'), // The item it appears as on the UI,
    'help' => t('Language of the user'),
    'field' => array(
      'id' => 'user_language',
      'click sortable' => TRUE,
    ),
    'sort' => array(
      'id' => 'standard',
    ),
    'filter' => array(
      'id' => 'node_language',
    ),
    'argument' => array(
      'id' => 'node_language',
    ),
  );

This piece of code wants to use a node_language argument plugin but it doesn't exist...
Not good ;)

Comment	File	Size	Author
#9	views-1778768-9.patch	3.28 KB	dawehner
#9
#5	language-fix.patch	339 bytes	aspilicious
#5

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

dawehner

German

CreditAttribution: dawehner commented 8 September 2012 at 13:35

dawehner--
dawehner--
dawehner--

The files should be in #1605332: Adapt language integration to d8 but the commit missed the language handler to be committed
Once the files are in there, we can directly use the language handlers there.

Comment #2

aspilicious CreditAttribution: aspilicious commented 8 September 2012 at 13:53

-<?php
-
-/**
- * @file
- * Definition of Views\node\Plugin\views\argument\Language.
- */
-
-namespace Views\node\Plugin\views\argument;
-
-use Drupal\views\Plugin\views\argument\ArgumentPluginBase;
-use Drupal\Core\Annotation\Plugin;
-
-/**
- * Argument handler to accept a language.
- *
- * @Plugin(
- *   id = "node_language",
- *   module = "node"
- * )
- */
-class Language extends ArgumentPluginBase {
-
-  function construct() {
-    parent::construct('language');
-  }
-
-  /**
-   * Override the behavior of summary_name(). Get the user friendly version
-   * of the language.
-   */
-  function summary_name($data) {
-    return $this->node_language($data->{$this->name_alias});
-  }
-
-  /**
-   * Override the behavior of title(). Get the user friendly version of the
-   * node type.
-   */
-  function title() {
-    return $this->node_language($this->argument);
-  }
-
-  function node_language($langcode) {
-    $languages = views_language_list();
-    return isset($languages[$langcode]) ? $languages[$langcode] : t('Unknown language');
-  }
-
-}

We deleted this file...

Comment #3

dawehner

German

CreditAttribution: dawehner commented 8 September 2012 at 14:07

That's right, but the patch should have added

Views\language\Plugin\views\argument\Language

Comment #4

aspilicious CreditAttribution: aspilicious commented 8 September 2012 at 15:13

Ah but that one is added so we should just point to the correct plugin...

Comment #5

aspilicious CreditAttribution: aspilicious commented 8 September 2012 at 18:24

Status:

Active

» Needs review

File	Size
language-fix.patch	339 bytes

See

<?php

/**
 * @file
 * Definition of Views\language\Plugin\views\argument\Language.
 */

namespace Views\language\Plugin\views\argument;

use Drupal\views\Plugin\views\argument\ArgumentPluginBase;
use Drupal\Core\Annotation\Plugin;

/**
 * Argument handler to accept a language.
 *
 * @ingroup views_argument_handlers
 *
 * @Plugin(
 *   id = "language",
 *   module = "language"
 * )
 */

Comment #6

dawehner

German

CreditAttribution: dawehner commented 8 September 2012 at 19:15

Status:

Needs review

» Needs work

This

+++ b/modules/user.views.incundefined
@@ -165,7 +165,7 @@ function user_views_data() {
       'id' => 'node_language',
     ),
     'argument' => array(
-      'id' => 'node_language',
+      'id' => 'language',

filter and argument should use language here. If you look at comment.views.inc you will find other instances of that as well, sry