ViewsObjectTypes really doesn't help to understand the purpose of the function.

CommentFileSizeAuthor
#4 views-1778148-4.patch16.49 KBdawehner
#1 views-1778148-1.patch15.98 KBdawehner
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Active » Needs review
FileSize
views-1778148-1.patch15.98 KB

Here is a version with a test.

Status: Needs review » Needs work

The last submitted patch, views-1778148-1.patch, failed testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented

Unfortunately, the plurals aren't that easy, or we'd just add 's' everywhere directly :)

empty, footer, header are the 3 failing ones.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs work » Needs review
FileSize
views-1778148-4.patch16.49 KB

Thanks for the review! It's a bit odd that some of my tests lie around untouched for a long time.

Oh, this was too easy.

What about adding a todo, and make a special check in the test for now? Renaming footer/empty/area would require us to change all default views
so would block a lot of other patches.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Needs review » Reviewed & tested by the community

Looking good!

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Reviewed & tested by the community » Fixed

Thank you! Committed and pushed.

Automatically closed -- issue fixed for 2 weeks with no activity.