Allow for ContainerAware controllers

Can we copy the issue summary into the class' phpDoc, please? :)

We're generally missing explanations for the new abstract concepts and builders, and more importantly reasonings for why they exist and why they're useful, at which point they're used/invoked, and how they relate to other classes, and so on. That would be a huge help for people who're looking at some of the code/files to understand what's going on.

Symfony itself improved a lot in its latest version with regard to that, but overall, doesn't set a good example. (Other frameworks are providing much more elaborate documentation in code to explain the usage and concepts.)

Once sun is happy with the docs, this looks RTBC to me.

oink - let's not overcomplicate it :) I was basically just asking to get from zero to something ;)

Let me try (not sure whether this is correct):
---

/**
Enhanced resolver to allow for ContainerAware controllers.

By implementing the ContainerAwareInterface, a controller may denote that it wants to have the dependency injection container passed into it wholesale.

Normally this is considered bad practice, but most request controllers in Drupal are supposed to contain minimal glue-code only in order to handle a callback, so injecting the entire container is easier than setting up the exact dependencies for each separate object.

@see Symfony\...\ContainerAwareInterface
@see ...
 */
class ControllerResolver extends BaseControllerResolver {

In that version, there is no longer a warning about this not being a recommended practice, as in the original text. Which means passing the container wholesale is likely to become quite frequent when newcomers discover the class without a best practices warning, since it is so convenient (oooh, I can have the whole global configuration if I use this controller, let's do this !)

Small nit... I think Drupal coding style calls for NULL (not null).

Thanks!

I started a code review, but then I realized that I could just as well fix the issues myself. I usually prefer to just review, so the problems don't get repeated in other patches... hopefully the interdiff will suffice.

+++ b/core/lib/Drupal/Core/ControllerResolver.php
@@ -0,0 +1,63 @@
+ * @file Definition of Drupal\Core\ControllerResolver;

For the @file directive, the summary should appear on the next line. Should also end in a period.

+++ b/core/lib/Drupal/Core/ControllerResolver.php
@@ -0,0 +1,63 @@
+   * Constructors a new ControllerResolver.

"Constructs"

...

The only changes are docs changes, as visible in the interdiff in #11.

I suspect we have another random test failure in Drupal\locale\Tests\LocaleFileImportStatus...

OK this looks reasonable to me, and thanks for the docs improvements. Committed/pushed to 8.x.

This broke the ability to use a method as a page callback: #1781560: Regression: Methods can no longer be used in page callbacks

Here is the functional test and test+fix. They can be replaced with unit tests, but should not be removed.

This should set the issue back to "needs work".

(sorry: answered another thread and ended on that one, please ignore)

Reuploading #21 with and without the tests, just to be sure the test works. But, RTBC because it makes sense.

Committed and pushed to 8.x. Thanks!