Check all checkbox should not appear if there are no checkboxes [#177556]

Comment	File	Size	Author
#9	tableselect.js_.v3.patch	1.65 KB	jrabeemer

#7	tableselect.js_.v2.patch	819 bytes	jrabeemer

#1	tableselect.js0_.patch	853 bytes	floretan

Comment #1

floretan CreditAttribution: floretan commented 16 October 2007 at 03:33

Assigned:	Unassigned	» floretan
Status:	Active	» Needs review

File	Size
tableselect.js0_.patch	853 bytes

Here's a patch for tableselect.js that checks that a table has at least one checkbox.

In the case where there is only one row/checkbox in the table, it would also work not to add the "select all" checkbox, but the display would be less consistent without it.

Log in or register to post comments

Comment #2

moshe weitzman CreditAttribution: moshe weitzman commented 16 October 2007 at 13:37

Priority:

Normal

» Minor

Log in or register to post comments

Comment #3

Freso CreditAttribution: Freso commented 26 October 2007 at 23:50

I'm a bit uncertain as to where this is an issue. Which page(s) is tableselect.js used on? (One can't test it if one doesn't know how or where to do so. :))

Log in or register to post comments

Comment #4

floretan CreditAttribution: floretan commented 28 October 2007 at 18:02

One of the places where this is used is on the content administration page at admin/content/node.

Log in or register to post comments

Comment #5

anders.fajerson CreditAttribution: anders.fajerson commented 29 October 2007 at 12:51

What's the drawback of having it displayed? The advantage is simpler code and a consistent UI.

Log in or register to post comments

Comment #6

jrabeemer CreditAttribution: jrabeemer commented 29 October 2007 at 12:55

Thanks for the patch flobruit. We just need to verify against the different browsers against the patch with the internal themes. Once that's done, I'm sure the patch will push to head.

Log in or register to post comments

Comment #7

jrabeemer CreditAttribution: jrabeemer commented 18 November 2007 at 22:26

Status:

Needs review

» Reviewed & tested by the community

File	Size
tableselect.js_.v2.patch	819 bytes

Thanks Flobruit. I updated the patch against HEAD and reduced the code a smidgen to remove the brackets to one line. This patch is dead simple and prevents the insertion of the checkall box into the table if there are no checkboxes. Tested against Safari 3.04 beta Windows, FF 2.0.0.9, IE7 Vista, and Opera 9.5 Alpha. Moving to RTBC.