Broke overlay with the dependency patch [#1772466]

In the JS dependency patch I did not put the right names in the overlay module.

When you put the right names, it works much better :)

Comment	File	Size	Author
	core-js-unbreak-overlay-libraries.patch	787 bytes	nod_

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

aspilicious CreditAttribution: aspilicious commented 3 September 2012 at 16:50

Status:

Needs review

» Reviewed & tested by the community

Damn js! :D

(This is tested!)

Comment #2

webchick

she/they

English

Vancouver 🇨🇦

CreditAttribution: webchick commented 4 September 2012 at 04:22

Priority:	Normal	» Critical
Status:	Reviewed & tested by the community	» Fixed

This is like the second time in two weeks we've managed to do this. I wonder if there's any way we could add even a rudimentary test to make sure that the overlay JS is making its way into the page when Overlay module is enabled. Hrm.

Anyway, committed and pushed to 8.x. Thanks!

Comment #3

tstoeckler

he/him

German

Essen, Germany

CreditAttribution: tstoeckler commented 4 September 2012 at 10:03

I wonder if there's any way we could add even a rudimentary test to make sure that the overlay JS is making its way into the page when Overlay module is enabled.

Just saw that comment and wanted to point to the fact that Libraries API (2.x) has these sort of pseudo-tests for checking that JavaScript and CSS is loaded. Specifically http://drupalcode.org/project/libraries.git/blob/refs/heads/7.x-2.x:/tes... should be useful for someone taking a stab at this.